Repository navigation
Build the DirichletBC interpolation loops once - #5577
Draft
sghelichkhani wants to merge 1 commit into
Draft
sghelichkhani wants to merge 1 commit into
sghelichkhani wants to merge 1 commit into
Conversation
DirichletBC with an expression value called interpolator.assemble on every update, which builds new loops each time. Keep the callable from _get_callable(tensor=...) and run it on each update instead.
sghelichkhani
force-pushed
the
sghelichkhani/pyop3-fix-bc-interpolation
branch
from
October 29, 2026 10:58
0c52dca to
d305a40
Compare
Contributor
|
Interpolator is going to be reworked in #5258, I don't think this needed |
Contributor
|
Also this code will be changed immenently by #5127 (merged to release) |
pbrubeck
marked this pull request as draft
October 29, 2026 12:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
DirichletBCwith an expression value callsinterpolator.assembleon every update, which builds new interpolation loops (and a new cache key) each time it is applied. This keeps the callable from_get_callable(tensor=...)and runs it on each update.#5258 rewrites these lines, and together with #5566 the repeated assemble would share its loops, so this PR is only needed until those land.
Tested on a branch that combines this with the other open pyop3 fixes: the Firedrake tests for assign, BCs, cofunctions, matrix-free, constants, Real spaces, equation BCs and adjoint pass on 1 to 3 ranks (the same failures as on
main), and the G-ADOPT regression suite runs with it.