Repository navigation
fix(deps): require icon version exporting ErrorIcon - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone CI installs @memohai/icon 0.20.0 from the lockfile, which does not export the ErrorIcon used by CalloutBanner, FieldError, FormMessage, and FieldStack. This causes four TS2305 errors on main and PR #41; the Memoh workspace link masks the mismatch locally.
Raise the dependency to ^0.21.0 and update only its lockfile entries. The published 0.21.0 package exports ErrorIcon, so standalone installs resolve the API these components require.
Validation:
Local validation used Node 24.14.1 and pnpm 10.33.0. GitHub CI runs Node 22. No visual changes.