Repository navigation
fix: keep sheet tab titles readable on macOS 27 - #452
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Segmented tab component src/config/ui.swift |
Adds a segmented picker and a stable-identity page stack. Unselected pages are hidden, disabled, and excluded from hit testing and accessibility. |
Font and input-method selector integrations src/config/FontView.swift, src/config/SelectInputMethod.swift, appium/test_font.py |
Replaces native tabs in both selectors with the segmented component. The font-selection test searches for the emoji font before checking that one match appears. |
Webview subproject reference
| Layer / File(s) | Summary |
|---|---|
Webview reference update fcitx5-webview |
Updates the subproject reference to commit 7e8ef6cca003392783aa1d7df8abe0b60c22ad34. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Possibly related PRs
- fcitx/fcitx5-macos#451: Introduced the previous fcitx5-webview commit referenced by this update.
Merge Risk: 
Minimal · up to beb51
-
The selector and webview changes are mergeable after normal checks.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 4 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
arm64 comparisonNo difference. x86_64 comparisonNo difference. |
On macOS 27, the Font and Add Input Methods sheets can compress their tab titles into ellipses, including the Chinese Font titles.
Replace both native TabViews with a shared
SegmentedTabViewthat sizes the selector independently of page content. It accepts any collection of unique Hashable tab values, preserves each page's state, and excludes inactive pages from interaction and accessibility. Make the font E2E search for its target before inspecting the row so it does not depend on locale-specific font ordering.Update
fcitx5-webviewfrom0fb887cto7e8ef6c, including the theme color transition improvements and macOS 27 scroll mode expand/collapse jitter fix.Validation on macOS 27.2:
Summary by CodeRabbit