Skip to content

fix: guard against unknown input contexts on destroy #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eagleoflqj merged 1 commit into from
Oct 19, 2026
Merged

fix: guard against unknown input contexts on destroy #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions macosfrontend/macosfrontend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,10 @@ void MacosFrontend::destroyInputContext(ICUUID uuid) {
// The only exception is when Instance is destroyed,
// InputContextManager deletes all InputContexts.
auto ic = findIC(uuid);
if (!ic) {
FCITX_ERROR() << "Cannot destroy unknown input context";
return;
}
// This check is necessary. Although system sends destroy event immediately
// after focus out for most scenarios, when using fn+E to call out emoji
// picker (com.apple.CharacterPaletteIM), the sequence is: user clicks emoji
Expand Down
Loading