Repository navigation
fix: prevent resaving already-saved regenerated session at end of request - #1155
Open
abdul-karim-mia wants to merge 1 commit into
Open
abdul-karim-mia wants to merge 1 commit into
abdul-karim-mia wants to merge 1 commit into
Conversation
…uest Signed-off-by: Abdul karim mia <97598943+abdul-karim-mia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
req.session.regenerate()is called prior toreq.session.save(),express-sessionwas still resaving the session to the store when the response finished.Cause
wrapmethodsonly wrappedreloadandsave. Whensess.regeneratereplacedreq.sessionwith a newly generated session instance, the new instance did not havesaveorreloadwrapped, so callingreq.session.save()did not updatesavedHash.originalIdretained the old session ID from before regeneration. BecauseoriginalId !== sess.id,isSaved(sess)evaluated tofalse, causingshouldSave(req)to trigger a duplicate save at the end of the request.Solution
sess.regenerateinwrapmethodsusingrewrapmethods.rewrapmethods, updateoriginalIdandoriginalHashto match the newly generated session, and resetsavedHashif the session ID changed.saveUninitialized: false).Fixes #935