Repository navigation
Conversation
The docs task now reads the project lock and recognizes organization repositories in seven- and eight-element Hex lock entries. For those dependencies, it builds URLs using the organization host, locked package name, and loaded application version. Other entries retain the existing URL format, and explicit dependency URL overrides still take precedence. The added regression test covers private direct and transitive dependencies, overrides, applications without version metadata, and fallback handling. Fixes elixir-lang#1975
josevalim
reviewed
Oct 11, 2026
| {:earmark_parser, "foo"} | ||
| end | ||
|
|
||
| test "includes private dependency URLs from the project lock", %{tmp_dir: tmp_dir} = context do |
Member
There was a problem hiding this comment.
Can we unit test them via the run function, as done by the other tests in this file?
Contributor
Author
There was a problem hiding this comment.
Done in 2f3ff36. The private lock test now calls run/3 against the current project with a temporary lockfile, same as the other tests here, and the throwaway Mix project is gone.
ericmj
reviewed
Oct 11, 2026
Private organization dependencies now link to https://<org>.hexorgs.pm/<package>/<vsn>/, as suggested in review. The private lock test now calls run/3 against the current project with a temporary lockfile, like the other tests in the file, instead of building a throwaway Mix project.
josevalim
requested changes
Oct 14, 2026
Read private dependency organizations from Mix.Dep.cached, keyed on dep.scm == Hex.SCM and dep.opts[:repo], instead of parsing the lock file. The test now seeds the cached deps rather than a temporary lockfile.
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/38755997496/artifacts/11989216134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs task now reads the project lock and recognizes organization repositories in seven- and eight-element Hex lock entries. For those dependencies, it builds URLs using the organization host, locked package name, and loaded application version. Generated documentation links for private Hex dependencies point to public HexDocs URLs instead of the organization’s documentation host, leaving those links broken unless explicitly overridden. Dependency URLs were built solely from the application name and loaded application version.
Tests for this live in
test/mix/tasks/docs_test.exs.Fixes #1975