Repository navigation
Conversation
With --meso-interpolate-pos, MSEdge::getMesoPositions does not let a vehicle move backwards, so a new position depends on the previously cached one. The cache was only updated when positions were queried. fcd-output queries every step while queue-output only queries queued vehicles, so the same scenario produced different queue lengths (and occasionally arrivals, since MEVehicle::hasArrived uses the position) depending on which other outputs were active. The positions of all occupied edges are now updated once per step before the outputs are written. The edge lock is taken since the gui draws from the same cache. Plain meso without --meso-interpolate-pos is not affected. Found while comparing micro and meso queue-output for eclipse-sumo#18388.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The positions of all occupied edges are now updated once per step before the outputs are written. The edge lock is taken since the gui draws from the same cache. Plain meso without --meso-interpolate-pos is not affected.
What I didn't check was its impact on simulation speed.