Skip to content

Update FMEA attribute name - #916

Merged
MaximilianSoerenPollak merged 7 commits into
eclipse-score:mainfrom
qorix-group:janisqrx_update_saf_analysis
Oct 8, 2026
Merged

MaximilianSoerenPollak merged 7 commits into
eclipse-score:mainfrom
qorix-group:janisqrx_update_saf_analysis

Conversation

@janis-qorix

Copy link
Copy Markdown
Contributor

📌 Description

Change the name of an attribute within the FMEA in order to be more specific.
root_cause was updates to failure_root_cause

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@AlexanderLanin

Copy link
Copy Markdown
Member

@janis-qorix thanks for the suggestion! Was this already discussed somewhere to rename the attribute?

ref gd_req__saf_attr_failure_root_cause only says Each FMEA may provide a short description of the root cause of the failure.

@MaximilianSoerenPollak

Copy link
Copy Markdown
Contributor

@janis-qorix thanks for the suggestion! Was this already discussed somewhere to rename the attribute?

ref gd_req__saf_attr_failure_root_cause only says Each FMEA may provide a short description of the root cause of the failure.

Ye this comes from the process template if I remember correctly.
It is failure_root_cause and should have been, it was just not correct here in DaC

@janis-qorix

Copy link
Copy Markdown
Contributor Author

@janis-qorix thanks for the suggestion! Was this already discussed somewhere to rename the attribute?

ref gd_req__saf_attr_failure_root_cause only says Each FMEA may provide a short description of the root cause of the failure.

@PandaeDo and I discussed this while maintaining the persistency FMEA. This Update shall bring more clarity within the safety analyses.

@janis-qorix
janis-qorix force-pushed the janisqrx_update_saf_analysis branch from a76ad31 to 1e46ab1 Compare October 7, 2026 07:24
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-916: https://eclipse-score.github.io/docs-as-code/pr-916/

:tags: Safety Analysis
:version: 1
:version: 2
:satisfies: gd_req__saf_attr_failure_root_cause

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a corresponding update in gd_req__saf_attr_failure_root_cause[version==2] maybe?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, cause this does only describe that it hsould be there.

image

The actually term is only described in the template which has no versioning ;/
Although it may should be the safety guide versioning then, or am I wrong?
@PandaeDo @janis-qorix

https://github.com/eclipse-score/process_description/blob/e05729bac856afffc3040c13495dd40736d13d48/process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst#safety-analysis-guidelines

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reset the version to 1, since there were no major changes included within the content of the requirement but only the naming itself.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-zw @AlexanderLanin thoughts on this?
Should we keep it version 1 or version 2 since the name of the attr changed?

@MaximilianSoerenPollak
MaximilianSoerenPollak merged commit 3893e35 into eclipse-score:main Oct 8, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants