Repository navigation
Conversation
As you may often just add a single path it is unecessary to wrap them in a list first. Example: `os.environ['PATH'] = join_path_var(wrapper, os.environ['PATH'])`
Flamefire
force-pushed
the
path-concat-3
branch
from
October 14, 2026 15:19
e6f5125 to
53e6564
Compare
Flamefire
force-pushed
the
path-concat-3
branch
from
October 15, 2026 08:36
53e6564 to
29e091e
Compare
Flamefire
force-pushed
the
path-concat-3
branch
from
October 15, 2026 10:57
29e091e to
80d73ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on previous changes to use
TEST_*constants.As pointed out in one of the PRs we should make the use of
path1 / path2instead ofos.path.join(path1, path2)consistent.Contains:
Pathinstances formain/parse_optionsargs #5325join_path_varaccept paths as separate arguments #5324