Repository navigation
Fix async examples in README - #2553
Merged
Merged
Conversation
The Future example compared the result to 2 instead of IO(2), and the FutureResult example passed the function instead of calling it.
Contributor
Merging this PR will not alter performance1 note
Comparing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2553 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 80 82 +2
Lines 2485 2692 +207
Branches 437 44 -393
==========================================
+ Hits 2485 2692 +207 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made things!
Two async examples in the README fail when copied and run.
The
Futureexample returns anIOcontainer, not a plain value:The
FutureResultexample passes the function instead of calling it:With the call fixed, the comparison is still
False, because two separateValueErrorinstances are not equal:This compares against
IO(2)in the first example, and in the second one callsraising()and checks the result type and its string form, the same waydocs/pages/future.rstdoes.Checklist
CHANGELOG.mdDocs-only change (README examples), so no new tests or CHANGELOG entry. I ran the fixed examples locally and the existing test suite passes.
Related issues
Refs #1618