Skip to content

feat(eon): populate MessageMetric properties from received metrics - #72

Merged
dpazj merged 3 commits into
masterfrom
feat/eon-message-metric-properties
Nov 4, 2026
Merged

dpazj merged 3 commits into
masterfrom
feat/eon-message-metric-properties

Conversation

@dpazj

@dpazj dpazj commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Decode Metric.properties when converting a received Sparkplug metric into a MessageMetric, instead of always setting properties to None
  • Add MessageMetricError::InvalidProperties so malformed property sets (e.g. key/value count mismatches) produce a descriptive error; the metrics iterator logs it and skips the metric, matching srad-app behavior
  • Add tests for valid property population and invalid property rejection

Closes the MessageMetric::properties item in the EoN section of TODO.md.

Verification

  • cargo test -p srad-eon
  • cargo clippy -p srad-eon --all-targets -- -D warnings
  • cargo fmt --check

@dpazj
dpazj merged commit 13c750f into master Nov 4, 2026
7 checks passed
@dpazj
dpazj deleted the feat/eon-message-metric-properties branch November 4, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant