Repository navigation
[release/8.0] Respect the difference between null/empty for owned collections mapped to JSON - #31831
Merged
Merged
Conversation
Contributor
Author
|
@ajcvickers fyi |
ajcvickers
force-pushed
the
fix29348_after_cleanup
branch
from
October 2, 2023 19:12
d3115c7 to
14d4469
Compare
ajcvickers
marked this pull request as ready for review
October 2, 2023 19:13
Contributor
|
@maumar built on your work and I think all cases are correct now. |
…lections mapped to JSON Fixes #29348 Fixes #31731 Collaboration between @maumar and @ajcvickers ### Description A empty collection of related entities is different from a null collection in both the EF model and JSON. This change ensures we preserve the difference. ### Customer impact JSON collections that should be non-null and empty as instead null leading to app crashes. ### How found Customer reported and internal testing. ### Regression Yes. ### Testing Added test coverage. ### Risk Low.
maumar
force-pushed
the
fix29348_after_cleanup
branch
from
October 3, 2023 03:00
14d4469 to
77bd25b
Compare
Contributor
Author
|
@ajcvickers changes look good, just added some cleanup in the tests, Github won't let me sign off on the pr, so you will have to push the button :) |
ajcvickers
approved these changes
Oct 3, 2023
roji
reviewed
Nov 14, 2023
| } | ||
| await context.SaveChangesAsync(); | ||
|
|
||
| var saved = context.Database.SqlQueryRaw<string>("select OwnedCollectionRoot from JsonEntitiesBasic where Id = 2").ToList(); |
Member
There was a problem hiding this comment.
@maumar this needs to normalize quotes, e.g. fails on PG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29348
Fixes #31731
Description
A empty collection of related entities is different from a null collection in both the EF model and JSON. This change ensures we preserve the difference.
Customer impact
JSON collections that should be non-null and empty as instead null leading to app crashes.
How found
Customer reported and internal testing.
Regression
Yes.
Testing
Added test coverage.
Risk
Low.