Repository navigation
Update stable Android dependencies for 20261005 - #1557
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
1. `com.google.android.gms:playservicesnearby` - 19.5.0 -> 19.5.1 2. `com.google.android.libraries.places:places` - 5.3.0 -> 6.0.2 3. `com.google.android.play:hsdp` - 2.1.0 -> 2.2.0 4. `com.google.guava:guava` - 33.7.1android -> 33.7.2android Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Keep Nearby, Places, HSDP, and Guava at versions available from the CI Maven mirror. Remove unrelated PublicAPI drift and regenerate governance and artifact metadata.
There was a problem hiding this comment.
🟡 Changes recommended
The implementation contradicts the PR description and does not complete the linked stable-update issue.
1 open finding
What changed in this PR
Intended as a weekly stable dependency update, but the diff instead documents restore blockers while refreshing previously missing generated metadata.
Changes:
- Records four dependency updates as blocked by Azure Artifacts.
- Adds Viewfinder and Espresso entries to generated metadata.
- Does not apply the dependency or ARCore updates described.
| File | Description |
|---|---|
config.json |
Documents blocked dependency updates. |
cgmanifest.json |
Adds three component-governance entries. |
docs/artifact-list.md |
Adds corresponding artifact mappings. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| "nugetId": "Xamarin.GooglePlayServices.Nearby", | ||
| "type": "xbd" | ||
| "type": "xbd", | ||
| "comments": "Temporarily held at 19.5.0 because Azure Artifacts cannot restore version 19.5.1 from Google Maven (401 Unauthorized)." |
There was a problem hiding this comment.
Addressed by correcting the PR description. It now explicitly states that no package versions are upgraded and lists the retained/deferred versions for Nearby, Places, HSDP, and Guava. Removed the outdated ARCore, PublicAPI, and package-upgrade API-diff claims, and explained that the generated metadata changes add three already-configured artifacts missing from the checked-in listings.
Replaced the automatic-closing reference with "Related to #1556" so the stable-update issue remains open for the deferred upgrades. The Azure feed restore problem is not resolved by this PR; those updates remain pending. No repository changes or new commits were made for this correction.
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
The complete four-file review found no high-confidence blocker. All non-comment configuration values are identical to the base, and all 704 active artifacts match the governance manifest and both complete generated listings in source order. The only additions are the three Viewfinder/Espresso artifacts already configured before this PR; retained records, versions, licenses and mappings remain consistent.
The corrected description accurately documents deferred upgrades rather than claiming completed package/API changes, and Related to #1556 preserves the outstanding update issue. That maintainer-accepted scope is retained despite the visually unresolved old thread. Independent static correctness, generator/build/publication integration and final completeness checks passed; no PR generators, restores, builds or tests were executed by the reviewer.
Documents the deferred stable dependency updates for 20261005 and synchronizes generated governance and artifact listings with the existing configuration. This PR does not upgrade any package versions.
Deferred package updates
The following versions were unavailable from the Azure Artifacts Maven mirror used by CI (401 Unauthorized), so the existing versions are retained:
Adds explanatory feed-hold comments to
config.json. The proposed ARCore binding and license addition have been removed; they are not part of the final diff.Generated metadata
Regenerates
cgmanifest.json,docs/artifact-list.md, anddocs/artifact-list-with-versions.md. This includes three artifacts already configured before this PR but missing from the checked-in generated metadata:androidx.camera.viewfinder:viewfinder-compose1.6.2androidx.camera.viewfinder:viewfinder-view1.6.2androidx.test.espresso:espresso-idling-resource3.7.0The artifact-list row numbers shift after these entries are added; this is not a package-version upgrade.
API and namespaces
No effective PublicAPI changes remain compared with the base branch. Unrelated generated API drift has been removed.
published-namespaces.txtwas regenerated after the complete build and is unchanged. There is no package-upgrade API diff.Validation
update-config, then retained versions available from the CI mirror.net10.0-android36.0solution build passed locally.Related to #1556. The stable package upgrades remain pending until the CI feed can restore the deferred versions; this PR should not close that issue as completed.