Repository navigation
Breaking change note: proxies throw for members whose accessors cannot be overridden - #5515
Draft
ajcvickers wants to merge 2 commits into
Draft
ajcvickers wants to merge 2 commits into
ajcvickers wants to merge 2 commits into
Conversation
…e navigations Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new EF Core 12.0 page is not discoverable because it is missing from the documentation TOC, and several statements overstate or ambiguously describe proxy behavior.
4 open issues
What changed in this PR
Adds the initial EF Core 12 breaking-changes page documenting validation errors when lazy-loading or change-tracking proxies cannot override required accessors.
Changes:
- Documents proxy accessor visibility requirements, previous silent failures, and new model-validation exceptions.
- Covers
InternalsVisibleTo, opt-outs, mitigations, and representative navigation and property examples.
| File | Description |
|---|---|
| entity-framework/core/what-is-new/ef-core-12.0/breaking-changes.md | Adds EF Core 12 breaking-change documentation for proxy accessor accessibility and validation behavior. |
Review effort: Lite
| @@ -0,0 +1,97 @@ | |||
| --- | |||
|
|
||
| #### New behavior | ||
|
|
||
| Starting with EF Core 12, model validation throws an <xref:System.InvalidOperationException> when a proxy cannot override the accessor it needs: |
Comment on lines
+71
to
+75
| The exception is not thrown: | ||
|
|
||
| - For a navigation on which lazy-loading is disabled with `EnableLazyLoading(false)`. | ||
| - For lazy-loading proxies when `IgnoreNonVirtualNavigations` is specified. The navigation is then not proxied and is not lazy-loaded, as before. | ||
| - For lazy-loading proxies when only the setter is not visible. Only the getter needs to be overridden, and lazy-loading proxies do not intercept properties. |
|
|
||
| - For a navigation on which lazy-loading is disabled with `EnableLazyLoading(false)`. | ||
| - For lazy-loading proxies when `IgnoreNonVirtualNavigations` is specified. The navigation is then not proxied and is not lazy-loaded, as before. | ||
| - For lazy-loading proxies when only the setter is not visible. Only the getter needs to be overridden, and lazy-loading proxies do not intercept properties. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change note for dotnet/efcore#39591 (fixes dotnet/efcore#32352) and dotnet/efcore#39592 (fixes dotnet/efcore#39589): lazy-loading and change-tracking proxies now throw during model validation when they cannot override an accessor they need, for example an
internal virtualnavigation, or a mapped property with{ get; internal set; }under change-tracking proxies, withoutInternalsVisibleTo("DynamicProxyGenAssembly2"). Before, such members were silently never loaded or never change-tracked.There are no EF Core 12 docs yet (
mainof dotnet/efcore is 12.0), so this addsef-core-12.0/breaking-changes.mdwith just this entry. I haven't touchedtoc.ymlor the 12.0 what's-new page.Overlap with #5511: that draft also creates
ef-core-12.0/breaking-changes.md(for themigrations --output-dirchange). The two PRs will conflict on the file header and the summary table; whichever merges second needs a trivial merge that keeps both rows.This should be merged together with dotnet/efcore#39591 and dotnet/efcore#39592, and stays a draft until those are merged. Note that #39592 is itself a draft stacked on #39591.
🤖 Generated with Claude Code