Repository navigation
[DIT-13670] Add bases support - #161
Conversation
ae6b10b to
5400259
Compare
5400259 to
0edd05c
Compare
bparrish17
left a comment
There was a problem hiding this comment.
looks good just a couple stylistic nits, take em or leave em
| /** Developer ID of the base */ | ||
| id: string; | ||
| /** True if the base is in the config, so its own text items are exported too */ | ||
| fetchBaseTextItems: boolean; |
There was a problem hiding this comment.
nit: this reads as an action not a boolean, shouldFetchBaseTextItems or something similar for clarity
| return requests; | ||
| } | ||
|
|
||
| private textItemSourceFilter(source: TextItemSource): PullFilters { |
There was a problem hiding this comment.
stylistic nit: do we have any conventions for denoting private methods? In the past ive prefixed them with underscore
There was a problem hiding this comment.
I just checked and every private method in the repo has a regular name, no specific conventions. I think just about every class method in this repo is either private or protected where protected just allows private methods to be used in test files.
Given that basically every method is private, i don't think we need to change the names to denote that. And it would be a huge diff if we did.
4c85bd6 to
748e92a
Compare
Overview
Adds support for pulling directly from bases, and updates project exports so they are grouped by connected base. Non-connected projects continue to go into their own project files, but all data from a given base will be placed into a single, combined base file, titled by the base's id, so that the API can handle any duplicates between the base and its connected projects.
Test Plan
Until it merges, you will need to point your
ditto-appto this branch:marla/dit-13880-empty-varmarla/dit-13867-always-use-exportand this branchprojectsexists in the config. Components should only be fetched ifcomponentsis in the config. They can both be fetched when both are specified.bases: -a-base-id(with a line break) and pullprojects: []-> This should fetch EVERY project in the workspace, grouped the same as describedbasesfrom the config -> The files should still be grouped the same as before - the projects connected to bases should still be grouped together and named by base, but only the text items present in those projects (and not the whole base) should be in the fileindex.jsfile should spread all base files, then project files, then components, in that order