Repository navigation
Fix tileset tile ID remapping after resize - #1260
Open
jamiemccarter wants to merge 1 commit into
Open
jamiemccarter wants to merge 1 commit into
jamiemccarter wants to merge 1 commit into
Conversation
## What was wrong Resizing a tileset could cause existing tile IDs to be remapped incorrectly. The remapping logic derived the previous column count from the old pixel width instead of using the tileset's stored grid width, and height-only expansion could trigger unnecessary remapping. ## What changed - Preserve the previous tile-grid width when remapping tile IDs. - Skip remapping when the tileset only grows vertically and its grid width is unchanged. - Continue remapping when the tile layout genuinely changes. ## Testing Built the project locally and imported assets using the updated build. Tileset resizing and tile IDs behaved as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Resizing a tileset could cause existing tile IDs to be remapped incorrectly. The remapping logic derived the previous column count from the old pixel width instead of using the tileset's stored grid width, and height-only expansion could trigger unnecessary remapping.
What changed
Testing
Built the project locally and imported assets using the updated build. Tileset resizing and tile IDs behaved as expected.