Skip to content

🤖 Workspace actions: comment follow-ups from #6461 #6518

Closed

Description

@ThomasK33

Comment-only follow-ups from the final independent check of #6461 (Workspace actions leftovers). None changes behavior.

  1. src/browser/components/WorkspaceMenuBar/WorkspaceHeaderTitle.tsx: the doc comment of WorkspaceHeaderTitleInput ("Enter or leaving the field saves, Escape cancels…") now sits above reportSaveError. Move it back above WorkspaceHeaderTitleInput.
  2. Same file, useSaveOnUnmount: the comment names only the workspace switch, but the save runs on any unmount while the draft is changed. Reword it (the behavior matches leaving the field).
  3. WorkspaceActionsMenuContent.tsx isInMenuPopover: the ?? root fallback is unreachable today (both callers mount the menu inside Radix PopoverContent). Optionally make it fail closed if a future caller mounts the menu outside a dialog.

Owner: the coordinator desk. Pick up with the next change to these files.


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $99.39

Activity

  1. added a commit that references this issue on Oct 15, 2026
    88e6be9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions