Repository navigation
Conversation
Member
Author
|
I think it was @MicahGale who proposed this erroneous addition, so we'll let him review :) |
Contributor
I proposed only |
MicahGale
reviewed
Sep 14, 2026
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write |
Contributor
There was a problem hiding this comment.
This allows the CI to write PR messages. Is it actually doing that? Also I am skeptical that contents: write is necessary.
Contributor
There was a problem hiding this comment.
Oh is the contents: write for committing updates from Zotero?
Contributor
There was a problem hiding this comment.
I still don't see why pull-requests: write is necessary.
MicahGale
requested changes
Oct 16, 2026
MicahGale
left a comment
Contributor
There was a problem hiding this comment.
I don't think pr write permissions are necessary most likely.
Member
Author
|
Closing in favor of #366 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added these hastily in review, but there was already a permissions block in the correct place and this caused failure.