Retry loading transfer schedules when the conductor is not ready - #537
Open
fabi200123 wants to merge 1 commit into
Open
fabi200123 wants to merge 1 commit into
fabi200123 wants to merge 1 commit into
Conversation
The cron loop starts from an os.register_at_fork after_in_child callback. CPython ignores exceptions raised there, so a MessagingTimeout while the conductor was still starting left transfer-cron running with the schedule loop never started and no retry. Load schedules from a background thread instead. On failure, retry every 60 seconds until the conductor responds.
fabi200123
marked this pull request as ready for review
October 1, 2026 12:04
petrutlucian94
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cron loop starts from an os.register_at_fork after_in_child callback. CPython ignores exceptions raised there, so a MessagingTimeout while the conductor was still starting left transfer-cron running with the schedule loop never started and no retry.
Load schedules from a background thread instead. On failure, retry every 60 seconds until the conductor responds.