Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FiatTokenUtil.Detail
transferWithMultipleAuthorizationsuses a low-level call and treats the EVM success bit as a successful transfer. Calls to addresses without deployed code return success with empty data, so a utility configured with such a target can report successful transfers without executing FiatToken logic.The constructor now uses OpenZeppelin's
Address.isContractto require that the immutable target already has deployed code. Correctly configured instances retain the same runtime behavior; the change only rejects invalid deployments earlier.Because
isContractrelies on deployed bytecode, the target must already be deployed when constructingFiatTokenUtil. Existing proxy-based deployments satisfy this requirement.Testing
yarn compileyarn static-checkyarn hardhat test test/v2/FiatTokenUtil.test.ts --no-compile— 3 passingforge test -vvv— 8 passingDocumentation
Issue #685 was updated with the repository-native regression test path. No user-facing documentation changes are required.
Requested Reviewers: Maintainers