Skip to content

fix: adjustments for OTELv3 - #229

Open
schiwekM wants to merge 13 commits into
mainfrom
fix/support-otel-v3
Open

schiwekM wants to merge 13 commits into
mainfrom
fix/support-otel-v3

Conversation

@schiwekM

Copy link
Copy Markdown
Collaborator

Verified with https://github.com/cap-js/telemetry/pull/567/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

  • Removes OTEL v1 handling
  • Adjustments for OTEL v3
  • Adjusted config of bookshop so that with the tracing profile it auto connects to LGTM / Jaeger for checking that everything works

Have you...

  • Added relevant entry to the change log?

@schiwekM
schiwekM requested a review from Akatuoro October 29, 2026 14:11
@schiwekM
schiwekM requested review from a team as code owners October 29, 2026 14:11
@sjvans

sjvans commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

hi @schiwekM

some background please. @cap-js/telemetry only supports otel 2. how could agents use 3?

Comment thread tests/utils/telemetry-utils.js Resolved
Comment thread lib/telemetry/mlflow/tracing.js Resolved
Comment thread tests/projects/bookshop/package.json Resolved
Comment thread CHANGELOG.md Resolved
@schiwekM

Copy link
Copy Markdown
Collaborator Author

hi @schiwekM

some background please. @cap-js/telemetry only supports otel 2. how could agents use 3?

Johannes gave me the task and for now it is just preparatory work for when @cap-js/telemetry supports v3 so that we don't have to play catch up in the future.

@Akatuoro

Copy link
Copy Markdown
Contributor

@cap-js/telemetry only supports otel 2. how could agents use 3?

Marten mentioned in the PR description that this is tested using your otel 3 branch in @cap-js/telemetry.

We can keep this open until @cap-js/telemetry supports v3... but agents does have code incompatible with otel v3... so this PR makes our code compatible.

It came to my attention due to the dependabot upgrades... and our users will also be getting these and won't be able to keep their versions up to date until then (for @opentelemetry/exporter-trace-otlp-proto)... keeping up with the newest versions is one of the top recommendations that we give

@sjvans

sjvans commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

we'll have a @cap-js/telemetry^3 latest end of q4 (but hopefully end of nov)

@schiwekM
schiwekM requested a review from Akatuoro October 30, 2026 14:39
@Akatuoro

Copy link
Copy Markdown
Contributor

we'll have a @cap-js/telemetry^3 latest end of q4 (but hopefully end of nov)

alright, then we'll explicitly stay on 2 for now, but already include the compatibility code for when cap-js/telemetry is ready

@Akatuoro
Akatuoro added this pull request to the merge queue Oct 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants