Repository navigation
feat: implement durable output knowledge and overlay architecture - #674
Open
ty-everett wants to merge 475 commits into
Open
ty-everett wants to merge 475 commits into
ty-everett wants to merge 475 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
10 of 15 tasks
16 of 25 tasks
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
19 of 39 tasks
15 of 17 tasks
Authenticate reserve genesis, activation and complete actual input Scripts for the current optional BRC-197 exemplar. Expose the full independently verified purchase commitment while preserving historical exports and original suites. Qualify 118 current/historical regression tests, original 300-run properties, 99.7% statement/96.8% branch boundary coverage, packed/browser contracts and 67 compiled examples. Register a separate complete-source critical mutation target without changing existing sources, selectors or thresholds. Collector, protected wallet, durable alias integration and full checkpoint-two qualification remain open; these are component results.
Preserve main89adc84 implementations and regression tests. Reconcile published baselines and additive branch release candidates without dropping either set of release/migration records; regenerate the shared documentation from source.
Add exact current C decoding, full descriptor schedule/expiry binding and a strict new-preparation stage/height predicate in the selected covenant entry. Preserve paid-lookup and historical interfaces and all original browser limits. Full buyer/seller, protected wallet and native alias migration remain open. Qualify the full 257-test LCH profile, current eight-recipient/unit/property cases, complete helper coverage, strict packed/browser exports and 68 compiled examples. Extend whole-source mutation registration without removing controls. Repair actual CI frontmatter failures and reconcile the measured 176-mutant purchase inventory plus additive 143-target/390-execution inventory counts; retain complete original semantic partition equality and runner settings.
Add the two imported current profile/key source inputs to all six existing common LCH support inventories, retaining every previous source, selector and control. Assert exact support presence alongside original common-inventory equality; all 119 governance and pinned-engine inventory checks pass.
…tion Resolve the current-head source-quality findings by factoring economic output planning, receipt construction and activation witness generation without changing public interfaces, programs, layouts or signer rules. Fixture guards explicitly retain the single seller-child request contract. All 414 SDK and 100 current/historical lineage regressions pass with original property controls; planner and witness boundary has complete line/function coverage.
Use Array.from with explicit lengths and values to satisfy both unchanged lint and Sonar rules while preserving exact metadata/witness bytes. The complete 414 SDK and 100 lineage/purchase regression profiles pass again with original 300-case and seed controls.
8 of 25 tasks
…ories pnpm audit --audit-level=high fails on main, so Build, lint, and policy and five infra jobs are red on every pull request. Two high advisories landed on 2026-10-20 for follow-redirects 1.16.0: GHSA-q3jh-wrc6-jgq8 array-form headers bypass cross-origin credential stripping GHSA-8r9p-f939-6h3c sensitiveHeaders regex escaping can expose credential headers Every dependent already admits the patched release (the workspace path is mongodb-memory-server-core, which asks for ^1.16.0), so this only moves the locked version to 1.16.1. No manifest or override changes. pnpm-lock.yaml workspace infra/message-box-server/package-lock.json infra/uhrp-server-basic/package-lock.json infra/uhrp-server-cloud-bucket/package-lock.json infra/uhrp-server-cloud-bucket/notifier/package-lock.json infra/wab/package-lock.json
Adopt the Vite security fields reviewed in c609ae2 and regenerate the lock for this branch's additional output-knowledge importers. Keep the existing follow-redirects 1.16.1 fix and all runtime, test, mutation and policy limits.
15 of 25 tasks
BraydenLangley
marked this pull request as ready for review
October 21, 2026 02:48
BraydenLangley
requested review from
BraydenLangley,
sirdeggen and
tonesnotes
as code owners
October 21, 2026 02:48
BraydenLangley
marked this pull request as draft
October 21, 2026 05:09
|
BraydenLangley
marked this pull request as ready for review
October 21, 2026 05:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Program and scope
This PR implements the opt-in BRC-192–199 application architecture from BRC PR #295: independent Overlay observations, progressive/resumable lookup, durable journals, authenticated private publication and paid acquisition, admission-linked STEAK/POTATOES delivery, optional LCH acquisition and root-host recovery. The BRC-197 reference family binds authenticated genesis/Script transitions, immutable shares, payouts, retained remainders and expiry retirement. Existing finite lookup, submission, GASP and ordinary BRC-170 behavior remains supported.
Current head:
0b5afd6d3cd501d845ce49516f50dfd2f38afa1d, including main41a6edb437b8757b6a76e38d7d59a88368aa5e83. The reconciliation adopts current-main SDK4/color while preserving this PR's BRC-192–199 implementation. Its ordinary wallet output adapter now rejects SDK4 decimal balance aggregates before emitting an empty-scan completion; zero and large-decimal regressions pass. Upstream and branch release notes, peer ranges, version candidates and generated facts are reconciled. All original mutation targets/policies and execution rows remain.Impact and compatibility
Candidates include SDK 4.0.0 and Templates 2.1.0, Overlay 2.7.0, Overlay Express 2.8.0, Wallet Toolbox/client/mobile 2.15.0, auth middleware 2.3.0, LCH 0.3.0, output-knowledge 0.1.0 and WebRTCPay 0.2.2. The release ledger records versions, baselines and migrations, including 23 dependent patch candidates. Existing peer compatibility and numeric quality floors are preserved; SDK4 peer support is additive.
Readiness repairs strengthen native SQLite ownership/refusal, acquisition/publication recovery, proposal inventory, HTTP parsing/disclosure and revenue-profile boundaries. The SDK reuses its existing Script encoder for conservative witness estimates, retaining exact 39,110/6,542-byte bounds, public defaults and ABI. Original cases, 300-history properties, seed/path, time/resource limits and public contracts remain intact.
Iterative acceptance and remaining qualification
Checkpoint 2 now distinguishes PR review/source merge from final Checkpoint 2 and publication. This follows the requested iterative approach: prioritize previous uncovered/invalid critical guards, then prior low-score financial/admission/disclosure boundaries; record the time, actual detection and unknowns from each bounded iteration. The mutation review contains the measured ledger, ranked queue, survivor analysis and stop rules.
Full Checkpoint 2 qualification is incomplete. The complete 154-target/401-row campaign and independent canonical reconciliation remain mandatory before final Checkpoint 2 and publication. Existing protected package/infrastructure/Marketplace release workflows enforce full qualification on the actual release source. This PR changes acceptance sequencing, without reducing executable policy, selectors, corpus, mutation-engine/runtime/native pins or deadlines, score/status thresholds or release controls. Reviewers should assess this sequencing and the explicitly listed remaining gaps before source merge.
Four whole-target diagnostics on last-code head
674895fpass the unchanged policy: foundation 91.93%, acquisition state 90.97%, proposal storage 90.02%, and hosted SDK profile spend 90.22%. They have zero uncovered/invalid/unexecuted mutations, but retain survivors and include timeouts in the score. They are separate actual results, not a combined full-campaign pass. The focused14fault HTTP diagnostic on674895f completed in45.507s with all41initial cases:11assertion kills/3internal-message survivors deliberately redacted at the public boundary; zero uncovered/invalid/unexecuted mutations. All production bytes/exact canonical tuples and original cases/properties/controls were independently verified. It is partial feedback, not a whole-target score.The publication-state whole diagnostic reached its original 45-minute cap after all 187 initial cases passed and produced no final score. The exhaustive attempt was cancelled for this iterative pivot after 44 reports/11 whole targets reconciled. Its failed campaign gate explicitly records cancelled dependencies. The previous source-specific failures, worker heap-OOM and two macOS V8 crashes remain preserved; a later successful Linux SDK diagnostic does not erase them. Purchase evidence, coordination, admission and publication qualification gaps remain listed in the review queue.
Validation
The SDK4 reconciliation at8a1e0d passed all19local checks using Node24.19/pnpm10.33.2, including complete workspace build,557root governance cases,652owning cases (460application/77SDK/35HTTP/70Overlay/10wallet-source), affected consumer/browser tests, health/lint/format/types/audit/docs-facts/docs-build. The final70308364b followup changes only two stale inventory-count assertions (153/400 to154/401). Its exact pinned-engine integration check,557root tests and seven health/lint/format/type/security/documentation checks all pass locally; production/package and mutation-policy bytes are unchanged from8a1e0d. The earlier code batch also passed the complete workspace build; 460 application, 35 HTTP, 70 Overlay and 77 SDK owning cases; mobile/client/LCH/docs suites; and SDK/output-knowledge/Overlay/Overlay Express packed consumers. These diagnostics retain their actual tested source, with all 5,505 tracked inputs and 14 controls frozen and checked. The successor source/dependency identity is recorded separately; there is no claim of a new full mutation qualification.
All five exact-head workflows passed: Codegen — reproducible OpenAPI types, Conformance, Container runtime contracts, CodeQL, CI. The repository merge gate validates selected jobs and expected scope skips. Exact-head Sonar has zero issues, including accepted/false-positive classifications, and zero unreviewed hotspots. Both CodeQL analyses are error/warning-free, with zero open alerts and no new dismissals. All24review threads are resolved. The test-only focused followup passes118normal evidence/coordinator cases and seven root checks. All11selected critical mutations and the4selected wallet-guard mutations are caught; the evidence note retains source identities, the first10kill/1survivor result, its corrected verifier-call assertion, and the interrupted53fault attempt. These partial diagnostics do not qualify the full campaign. Full Checkpoint2/prepublication qualification remains incomplete. Source merge requires one qualified human approval, including review of acceptance sequencing and remaining qualification gaps.
Security and release
Reviewed follow-redirects 1.16.1 from #1270 and current-main Vite 8.3.4 pins and closure are included. Frozen ignore-scripts installation, audited esbuild rebuild and high/critical audit pass; one existing low and one moderate advisory remain below the unchanged high threshold. There is no new override, dismissal, exclusion, skipped case or suppression. Runtime/native pins and numeric gates remain unchanged.