Skip to content

Error combining with 6to5ify #39

Open

Description

@akulapid

I'm trying to do a brfs transform after 6to5ify, but get the following error.

browserify()
    .require("main", { entry: true })
    .transform(6to5ify)
    .transform(brfs)
    .bundle()
    .pipe(fs.createWriteStream(path.join('app.js')));
events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: tried to statically call { readFile: [Function: readFile], readFileSync: [Function: readFileSync], readdir: [Function: readdir], readdirSync: [Function: readdirSync] } as a function while parsing file: /Users/akula/foo/main.js while parsing file: /Users/akula/foo/main.js
    at error (/Users/akula/foo/node_modules/brfs/node_modules/static-module/index.js:71:49)
    at traverse (/Users/akula/foo/node_modules/brfs/node_modules/static-module/index.js:247:24)
    at walk (/Users/akula/foo/node_modules/brfs/node_modules/static-module/index.js:216:13)
    at walk (/Users/akula/foo/node_modules/brfs/node_modules/static-module/node_modules/falafel/index.js:60:9)
    at /Users/akula/foo/node_modules/brfs/node_modules/static-module/node_modules/falafel/index.js:51:25
    at Array.forEach (native)
    at forEach (/Users/akula/foo/node_modules/brfs/node_modules/static-module/node_modules/falafel/index.js:8:31)
    at /Users/akula/foo/node_modules/brfs/node_modules/static-module/node_modules/falafel/index.js:49:17
    at Array.forEach (native)
    at forEach (/Users/akula/foo/node_modules/brfs/node_modules/static-module/node_modules/falafel/index.js:8:31)

btw, there's a double "while parsing file" in the message.

My main.js looks like this.

import fs from 'fs';

var foo = fs.readFileSync(__dirname + '/foo.html');
console.log(foo.toString());

If I change the import to a require and don't do 6to5ify it works fine, but together it gives the error.

Activity

  1. erykpiast commented on Feb 5, 2015

    @erykpiast

    Ack! The same problem with 6to5@3.1.2 and brfs@1.3.0 on Node@0.10.25 for Linux.

  2. erykpiast commented on Feb 5, 2015

    @erykpiast

    But it works perfectly fine when used like

    var fs = require('fs');
    var content = fs.readFileSync(__dirname + '/file', 'utf8');
    

    I don't have to disable 6to5.

  3. vegetableman commented on Feb 28, 2015

    @vegetableman

    Faced this problem as well.

  4. danharper commented on Mar 5, 2015

    @danharper

    I'm guessing this is down to how Babel (was: 6to5) transpiles ES6 imports. This:

    import fs from 'fs'

    Becomes this:

    var _interopRequire = function (obj) { return obj && obj.__esModule ? obj["default"] : obj; };
    
    var fs = _interopRequire(require("fs"));

    If you want to go this route, resorting to a regular require call works fine:

    var fs = require('fs');
  5. nicroto commented on Mar 18, 2015

    @nicroto

    Just hit that, too.

  6. lambdabaa commented on Apr 8, 2015

    @lambdabaa

    agh

  7. dustinmoorenet commented on Apr 8, 2015

    @dustinmoorenet

    👍

  8. revolunet commented on May 28, 2015

    @revolunet

    looks like static-module has been updated with ES6 support ? browserify/static-module@2eb7ce0

  9. jedrichards commented on Sep 16, 2015

    @jedrichards

    I'm using brfs 1.4.1 which pulls in static-module 1.1.3 and still can't get brfs to work happily with ES6/babelify. Using same workaround as others for the moment, var fs = require('fs').

  10. tomek-he-him commented on Sep 16, 2015

    @tomek-he-him

    @jedrichards after some time using import for importing CommonJS modules I realized it’s really a kind of hack. fs is a CommonJS module and const fs = require('fs') seems the right thing to do to me.

    import is intended for real modules which use export for exporting things. And fs is not one of these yet.

  11. added a commit that references this issue on Oct 8, 2015
    d9992dc
  12. txwizard commented on Apr 24, 2018

    @txwizard

    Tou say "import is intended for real modules which use export for exporting things. And fs is not one of these yet."

    Over the last few days, I have created and imported modules that use both the module.exports and the plain export idiom. I have working modules that import one of each.

    Mixed_Imports.zip contains GridProperties.js, which imports both CommonConstants.js, which uses the plain export idiom, and PropertyDisplayHelpers.js, which uses the module.exports idiom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions