Repository navigation
Stop promoting double and round discrete quantiles up by default - #1554
Merged
Merged
Conversation
Collaborator
Author
|
@jzmaddock , @mborland , @ckormanyos : This is the "big one", as they say. Hopefully the ulps triage merge will make this painless for everyone. |
This was referenced Oct 11, 2026
NAThompson
force-pushed
the
no-double-promotion
branch
3 times, most recently
from
October 11, 2026 20:11
eeda001 to
3df4084
Compare
NAThompson
force-pushed
the
no-double-promotion
branch
2 times, most recently
from
October 11, 2026 23:42
e0b2eca to
5761ef9
Compare
promote_double is now false, with the test tables keyed on it; integer_round_up is the default discrete quantile; discrete_legendre uses explicit fma, so contraction can't make it disagree with itself. Closes #1211 Closes #1203 Co-authored-by: Reimar Döffinger <reimar.doeffinger@arm.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NAThompson
force-pushed
the
no-double-promotion
branch
from
October 12, 2026 02:46
5761ef9 to
2154108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two breaking default changes, each restorable with one macro:
dlp(x, k)anddlp.next()disagreed by up to hundreds of ulps on MSVC and clang-18. Develop's CI fails the same way.Closes #1211
Closes #1203
🤖 Generated with Claude Code