Repository navigation
RSpec: disable monkey patching - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
By default, RSpec adds
describe(and friends) to the top-level object and toModule, so specs can calldescribewithout theRSpec.prefix. RSpec's "zero monkey patching mode" turns that off, so RSpec doesn't modify core Ruby classes while the specs run. It's the recommended setup in the generatedspec_helper.rb, and RSpec 4 is expected to make it the default.What changed
spec/spec_helper.rbcallsconfig.disable_monkey_patching!.describein each of the eight spec files is nowRSpec.describe. Each file already had only one.The specs only use the
expectsyntax, so nothing else needed to change.How it was verified
bundle exec rake: 34 + 4 examples, 0 failures.Risk
None for users of the gem: only spec files change.