Skip to content

Remove redundant coding comments - #18

Merged
olleolleolle merged 1 commit into
masterfrom
drop-coding-comment
Nov 16, 2026
Merged

olleolleolle merged 1 commit into
masterfrom
drop-coding-comment

Conversation

@olleolleolle

@olleolleolle olleolleolle commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Why

# coding: utf-8 / # encoding: utf-8 was needed in Ruby 1.9, where source files defaulted to US-ASCII. Since Ruby 2.0, UTF-8 is the default source encoding, so the comment has no effect.

What changed

Removed the coding comment from sie.gemspec, spec/integration/parser_spec.rb, spec/unit/document/renderer_spec.rb and spec/unit/document_spec.rb. Where the comment was followed by a blank line, that line went too.

spec/unit/document_spec.rb (with "å" and "ö") and spec/unit/document/renderer_spec.rb (with "☃") contain non-ASCII characters. They still pass, because Ruby reads source files as UTF-8 by default.

How it was verified

  • The gemspec loads.
  • bundle exec rake: 34 + 4 examples, 0 failures.

Risk

None: the comment was already a no-op.

@olleolleolle
olleolleolle merged commit 955f476 into master Nov 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant