Repository navigation
Remove redundant coding comments - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
# coding: utf-8/# encoding: utf-8was needed in Ruby 1.9, where source files defaulted to US-ASCII. Since Ruby 2.0, UTF-8 is the default source encoding, so the comment has no effect.What changed
Removed the coding comment from
sie.gemspec,spec/integration/parser_spec.rb,spec/unit/document/renderer_spec.rbandspec/unit/document_spec.rb. Where the comment was followed by a blank line, that line went too.spec/unit/document_spec.rb(with "å" and "ö") andspec/unit/document/renderer_spec.rb(with "☃") contain non-ASCII characters. They still pass, because Ruby reads source files as UTF-8 by default.How it was verified
bundle exec rake: 34 + 4 examples, 0 failures.Risk
None: the comment was already a no-op.