[JohnStrunk]

Summary

Fixes #2188. Adds shared end-to-end assertions for VolSync synchronization status, conditions, and temporary-resource cleanup.

• Adds roles/verify_sync_status with completion, continuous, and validation-error modes.
• Integrates the role at 82 sync checkpoints across all 36 playbooks that create ReplicationSources or ReplicationDestinations. The three CR-free utility playbooks remain unchanged.
• Adds a no-mover ReplicationSource test that checks Synchronizing=False, reason Error, and the expected validation message.
• Regenerates the upstream/downstream custom-scorecard configs to include the new test.
• Adds the CR UID cleanup label to mover Job Pod templates so Pod cleanup is verifiable per CR. The role also checks the latest ReplicationDestination image remains present.
• Documents the continuous-mover exception and upgrade behavior for immutable mover Job templates.

Walkthrough

The shared role checks settled WaitingForManual/WaitingForSchedule success, mover result, timing and schedule status, latest-image existence, and cleanup-labeled PVCs, VolumeSnapshots, Jobs, and Pods. Continuous mode handles always-on Syncthing and untriggered movers without falsely requiring an idle state. Error mode covers a validation failure before a mover starts.

Showboat walkthrough and repeatable syntax-check evidence

Demo: Not applicable; this is test infrastructure and adds no user-facing runtime feature. No live e2e was run because the playbooks require a disposable Kubernetes cluster.

Verification

• Ansible syntax check passed for all 39 test_*.yml playbooks.
• Go tests passed for the Restic, Rclone, Rsync, and Rsync-TLS mover packages.
• Targeted pre-commit checks passed (YAML, Markdown, whitespace, and file formatting).
• CodeRabbit review of the shared role reported no findings.
• No cluster was created or mutated; live e2e behavior and timing remain unverified.
• The proposed no-op reconcile spot check is deferred: there is no status.observedGeneration to prove completion without a fixed, flaky sleep; existing controller tests cover reconcile idempotence.

(AI generated)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JohnStrunk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.5%. Comparing base (2602797) to head (e0091f4).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2194   +/-   ##
=====================================
  Coverage   68.4%   68.5%           
=====================================
  Files         61      61           
  Lines       6213    6217    +4     
=====================================
+ Hits        4255    4259    +4     
  Misses      1636    1636           
  Partials     322     322           

Files with missing lines	Coverage Δ
internal/controller/mover/rclone/mover.go	72.2% <100.0%> (+0.1%)	⬆️
internal/controller/mover/restic/mover.go	80.5% <100.0%> (+<0.1%)	⬆️
internal/controller/mover/rsync/mover.go	76.7% <100.0%> (+<0.1%)	⬆️
internal/controller/mover/rsynctls/mover.go	69.9% <100.0%> (+<0.1%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.