Set default region for CRT transfer clients - #10705
Merged
Merged
Conversation
Contributor
|
Worth adding regression blackbox tests. Probably not in this PR because blackbox tests have not been merged yet. |
ashovlin
reviewed
Sep 29, 2026
|
|
||
| def _resolve_crt_client_region(self, params): | ||
| # Match botocore, which signs for us-east-1 when no region is set. | ||
| return self._resolve_region(params) or 'us-east-1' |
Member
There was a problem hiding this comment.
I think this works, but looking at the Python plumbing I think we're actually resolving aws-global out of endpoints.json, which is then mapped to us-east-1 via the endpoint rules.
If possible, I'd rather honor the same source of truth instead of a new hardcoded ue-east-1.
ashovlin
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10703
When the transfer client is resolved to CRT and there's no region configured, the AWS CLI errors with 255 exit code. This is because CRT client creation asserts that a region is passed. This PR updates the CRT client constructor so it mirror's botocore's behavior of using the global endpoint/us-east-1 and letting the redirect handler resolve potential redirect errors.