Repository navigation
fix(hal): use spl_object_id() for circular reference counters - #8657
Merged
Merged
Conversation
spl_object_hash() is deprecated in PHP 8.6, and the HAL ItemNormalizer calls it in isHalCircularReference() on every item it normalizes. The hash is only used as a key for the circular reference counters, so spl_object_id() is a drop-in replacement (same change as doctrine/dbal#7518).
dualfroz
force-pushed
the
fix/hal-spl-object-id
branch
from
October 8, 2026 09:42
835c0b9 to
5704820
Compare
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spl_object_hash()is deprecated in PHP 8.6, and the HALItemNormalizercalls it inisHalCircularReference()on every item it normalizes. The hash is only used as a key for the circular reference counters, sospl_object_id()is a drop-in replacement (same change as doctrine/dbal#7518).ValidationException::getId()still usesspl_object_hash(), but its value ends up in the error IRI, so it is left out of this fix.