Repository navigation
[ZEPPELIN-6740] Add local Storybook foundation for AI Assistant UI - #5562
Open
voidmatcha wants to merge 5 commits into
Open
voidmatcha wants to merge 5 commits into
voidmatcha wants to merge 5 commits into
Conversation
voidmatcha
changed the base branch from
temp/voidmatcha/assistant-prerequisites
to
branch-voidmatcha-assistant-prerequisites-temp
October 9, 2026 01:35
voidmatcha
force-pushed
the
voidmatcha/assistant-v2-4-storybook
branch
from
October 9, 2026 02:34
c2c2ae4 to
7df7750
Compare
Member
Author
|
This PR adds local Storybook setup and a temporary theme-check story. The current diff is +3,742/-483 across 24 files. Excluding the lockfile (+3,082/-477) and 131 lines in The local Storybook build, two browser tests, eight theme tests, typecheck, and production build pass. This depends on #5558. Review and approval can happen now, but I will wait for #5558 to merge, then rebase this branch onto the latest |
voidmatcha
force-pushed
the
branch-voidmatcha-assistant-prerequisites-temp
branch
from
October 10, 2026 13:40
4235999 to
95bd1b7
Compare
voidmatcha
force-pushed
the
voidmatcha/assistant-v2-4-storybook
branch
from
October 10, 2026 13:40
ad66543 to
90f2626
Compare
Build and test Storybook on pushes, then publish each branch under its own Pages path when enabled. Let GitHub Pages rebuild automatically after the gh-pages push. Remove the privileged PR publisher and its cleanup machinery, and keep documentation focused on local use and the branch link. Confidence: medium Scope-risk: Pages publishing depends on repository settings and branch-based Pages builds. Not-tested: Public Pages URL after deployment.
The existing push trigger already scopes publication to branch builds. Remove the repository variable gate so fork pushes publish previews without an administrator-controlled setting. Confidence: high Scope-risk: Push runs in repositories with Pages permissions now attempt publication. Not-tested: GitHub Pages publication after push.
Remove the Storybook workflow and its branch Pages instructions. Contributors can run and verify the stories locally, while hosted links can be shared separately when needed. Confidence: high Scope-risk: Storybook no longer has a dedicated CI check. Not-tested: External preview hosting is outside this PR.
Bring vanilla-extract CSS and Playwright to the current stable releases. Keep distribution license entries for the bundled styling packages and remove the development-only Storybook entry. Confidence: high Scope-risk: The newer Playwright browser revision changes local test setup. Not-tested: Full Zeppelin distribution assembly.
voidmatcha
force-pushed
the
branch-voidmatcha-assistant-prerequisites-temp
branch
from
October 11, 2026 11:30
95bd1b7 to
397a5df
Compare
voidmatcha
force-pushed
the
voidmatcha/assistant-v2-4-storybook
branch
from
October 11, 2026 11:30
90f2626 to
022cb5c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add a local Storybook foundation so contributors can inspect and test Assistant UI components without running a Zeppelin server. This PR includes a temporary theme-check story; later UI work can add component and interaction stories. Hosted previews can be shared separately when needed.
Apache Superset documents a similar workflow in its Storybook guide and provides a public component reference.
Depends on #5558.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6740
How should this be tested?
Run from
zeppelin-web-angular/projects/zeppelin-react/:npm ci npm run storybook npm run build:storybook npx playwright install chromium npm run test:storybook npm test -- src/shared/ui/assistant-themeThe browser tests serve the built output locally. Set
STORYBOOK_PORTif port 6007 is occupied.Screenshots (if appropriate)
N/A
Questions: