Repository navigation
[CI] Pin JDK 17 for spotless and Ubuntu 24.04 for the Python extension build - #3499
Merged
Merged
Conversation
…n build GitHub moved ubuntu-latest to the Ubuntu 26.04 image, which breaks two workflows: - Manual hooks: the image's default JDK is now 25. google-java-format 1.15.0 (used by spotless) calls a javac internal API whose signature changed, so `mvn spotless:apply` fails with NoSuchMethodError on Log$DeferredDiagnosticHandler.getDiagnostics(). Set up JDK 17, the default on the previous image. - Python build extension: actions/setup-python has no Python 3.8 or 3.9 builds for Ubuntu 26.04, and requires-python is still >=3.8. Run the Linux leg on ubuntu-24.04.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[CI] my subjectWhat changes were proposed in this PR?
GitHub moved
ubuntu-latestto the Ubuntu 26.04 image. Two workflows have failed on open PRs since then (#3461, #3484, #3485).Manual hooks: the default JDK on the new image is 25 instead of 17. google-java-format 1.15.0, which spotless uses, calls a javac internal API whose signature changed, so
mvn spotless:applyfails withNoSuchMethodError: 'java.util.Queue com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics()'. The workflow now sets up JDK 17 withactions/setup-java, using the same pinned SHA as the other workflows.Python build extension:
actions/setup-pythonhas no Python 3.8 or 3.9 builds for Ubuntu 26.04, so the 3.8 job fails at setup and fail-fast cancels the other Linux jobs.requires-pythonis still>=3.8, so the Linux leg now runs onubuntu-24.04instead of dropping those versions.The other
ubuntu-latestjobs (pre-commit, wheels, links, CodeQL) pass on 26.04 and are unchanged.How was this patch tested?
mvn spotless:check -pl commonon master: it fails with the sameNoSuchMethodErroron Temurin 25.0.4.1 and passes on JDK 17.actions/python-versionsmanifest: no 3.8 or 3.9 x64 builds exist for 26.04, while 24.04 has 3.8.18 and 3.9.25.Did this PR include necessary documentation updates?