Repository navigation
[GH-3407] Use community MinIO fork image for S3 reader tests - #3408
Merged
Merged
Conversation
james-willis
marked this pull request as ready for review
September 25, 2026 22:09
jiayuasu
approved these changes
Sep 26, 2026
jiayuasu
added a commit
to kalayciburak/sedona
that referenced
this pull request
Sep 26, 2026
Keep the MinIO S3 test image from upstream apache#3408 and remove the branch-only image builder and Dockerfile. The remaining PR diff contains only the KNN join fix, its tests, and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes java.yml S3 reader tests fail: MinIO test image no longer publicly pullable #3407What changes were proposed in this PR?
MinIO has withdrawn its public container images.
quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Zno longer resolves, and Docker Hubminio/miniodenies anonymous pulls. As a result, the two S3 tests inGeoPackageReaderTestandOsmReaderTestfail on everyjava.ymlrun.This PR switches both tests to
pgsty/minio:RELEASE.2026-08-04T00-00-00Z, a community-maintained fork ofminio/miniopublished on Docker Hub. It is still marked.asCompatibleSubstituteFor("minio/minio"). The fork keeps the upstream image layout:minioentrypoint, port 9000,MINIO_ROOT_USER/MINIO_ROOT_PASSWORD, and the/minio/health/livehealth endpoint. SoMinIOContainer, theio.minioclient, and the S3A path-style settings all stay as they are, and the change is two lines.Alternatives considered:
MinIOContainerand the test helpers in every Spark module. Recent LocalStack images also need an auth token.bitnamilegacy/miniois frozen and receives no updates.latest, so the version can't be pinned.Other uses: I found no other references to MinIO images in python/, R/, docker-compose files, or docs.
How was this patch tested?
docker pull pgsty/minio:RELEASE.2026-08-04T00-00-00Zsucceeds anonymously. The tag is multi-arch (amd64/arm64).mvn -pl spark/common test -Dtest=none -DfailIfNoTests=false -DwildcardSuites=org.apache.sedona.sql.GeoPackageReaderTest,org.apache.sedona.sql.OsmReaderTestreportedTests: succeeded 34, failed 0, including both S3 tests.License
pgsty/miniois licensed AGPL-3.0 (repo). That is the same license as thequay.io/minio/minioimage these tests already used, so the license posture doesn't change.org.testcontainers:testcontainers-minio,io.minio:minio) are Apache-2.0 and unchanged.Did this PR include necessary documentation updates?