Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

PARQUET-752: Account for upstream Arrow API changes - #180

Closed
wesm wants to merge 5 commits into
apache:masterfrom
wesm:PARQUET-752
Closed

wesm wants to merge 5 commits into
apache:masterfrom
wesm:PARQUET-752

Conversation

@wesm

@wesm wesm commented Oct 17, 2016

Copy link
Copy Markdown
Member

As soon as ARROW-261/317 are merged, I'll update the thirdparty git SHA so we can get a green build

namespace parquet {
namespace arrow {

namespace BitUtil = ::arrow::BitUtil;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know this would work. Why not use using here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using doesn't work with namespaces AFAICT

@wesm

wesm commented Oct 18, 2016

Copy link
Copy Markdown
Member Author

Updated the thirdparty SHA. Guess I may have to wait til morning for the OS X builds

@wesm

wesm commented Oct 18, 2016

Copy link
Copy Markdown
Member Author

The externalproject changes in Arrow broke the build, looking into it

@wesm

wesm commented Oct 18, 2016

Copy link
Copy Markdown
Member Author

+1

@asfgit asfgit closed this in 82515fe Oct 18, 2016
@wesm
wesm deleted the PARQUET-752 branch October 18, 2016 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants