Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3787 +/- ##
===========================================
+ Coverage 57.74% 58.57% +0.82%
===========================================
Files 488 492 +4
Lines 40080 40388 +308
===========================================
+ Hits 23145 23658 +513
+ Misses 15157 14957 -200
+ Partials 1778 1773 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Upgrade
tools/protoc-gen-triple-openapifromlibopenapi v0.38.7tov0.42.3. The old version callsyaml.Dumper.SetIndent, which was removed ingo.yaml.in/yaml/v4 v4.0.0-rc.7and causes the generator to fail to compile when that YAML dependency is upgraded.The newer libopenapi uses
github.com/pb33f/go-yaml v0.1.1. Switch the generator's two YAML imports to the same package so its extension and enum nodes match libopenapi's types, and remove the direct dependency ongo.yaml.in/yaml/v4. Refresh the module checksums and required transitive dependencies.libopenapi now requires Go 1.26.0, so update this tool's module directive and both READMEs. The root module's dependencies and Go requirement are unchanged. Existing YAML and JSON golden files pass without modification.
Related: #3785, #3786.
Validation
Run in
tools/protoc-gen-triple-openapiwith Go 1.26.3, windows/amd64:go test ./... -count=1— passed, including YAML/JSON golden comparisons, proto3 optional fields, and ErrorResponse name collisions.go build ./...— passed.go vet ./...— passed.gofmton the two changed Go files andgit diff --check— clean.The repository-wide suite was not run because this change is confined to the standalone generator module. The example output was verified through the existing descriptor-based tests; a separate protoc invocation was not run.