Skip to content

build(tools): upgrade OpenAPI generator dependencies - #3787

Open
Alanxtl wants to merge 2 commits into
apache:developfrom
Alanxtl:codex/upgrade-openapi-dependencies
Open

Alanxtl wants to merge 2 commits into
apache:developfrom
Alanxtl:codex/upgrade-openapi-dependencies

Conversation

@Alanxtl

@Alanxtl Alanxtl commented Nov 2, 2026

Copy link
Copy Markdown
Member

Description

Upgrade tools/protoc-gen-triple-openapi from libopenapi v0.38.7 to v0.42.3. The old version calls yaml.Dumper.SetIndent, which was removed in go.yaml.in/yaml/v4 v4.0.0-rc.7 and causes the generator to fail to compile when that YAML dependency is upgraded.

The newer libopenapi uses github.com/pb33f/go-yaml v0.1.1. Switch the generator's two YAML imports to the same package so its extension and enum nodes match libopenapi's types, and remove the direct dependency on go.yaml.in/yaml/v4. Refresh the module checksums and required transitive dependencies.

libopenapi now requires Go 1.26.0, so update this tool's module directive and both READMEs. The root module's dependencies and Go requirement are unchanged. Existing YAML and JSON golden files pass without modification.

Related: #3785, #3786.

Validation

Run in tools/protoc-gen-triple-openapi with Go 1.26.3, windows/amd64:

  • go test ./... -count=1 — passed, including YAML/JSON golden comparisons, proto3 optional fields, and ErrorResponse name collisions.
  • go build ./... — passed.
  • go vet ./... — passed.
  • gofmt on the two changed Go files and git diff --check — clean.

The repository-wide suite was not run because this change is confined to the standalone generator module. The example output was verified through the existing descriptor-based tests; a separate protoc invocation was not run.

@Alanxtl
Alanxtl changed the base branch from main to develop November 2, 2026 03:29
@Alanxtl Alanxtl added ❗ Breaking Change 3.3.3 version 3.3.3 dependencies Pull requests that update a dependency file labels Nov 2, 2026
@Alanxtl Alanxtl linked an issue Nov 2, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.57%. Comparing base (555a9ba) to head (9e998e2).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3787      +/-   ##
===========================================
+ Coverage    57.74%   58.57%   +0.82%     
===========================================
  Files          488      492       +4     
  Lines        40080    40388     +308     
===========================================
+ Hits         23145    23658     +513     
+ Misses       15157    14957     -200     
+ Partials      1778     1773       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.3 version 3.3.3 ❗ Breaking Change dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please test go-yaml rc.7 before the November 4 release

2 participants