Skip to content

style(config-ui): apply prettier formatting to src - #9400

Open
DoDiODev wants to merge 1 commit into
apache:mainfrom
DoDiODev:pr/config-ui-prettier-drift
Open

DoDiODev wants to merge 1 commit into
apache:mainfrom
DoDiODev:pr/config-ui-prettier-drift

Conversation

@DoDiODev

Copy link
Copy Markdown
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests. (N/A: formatting only)
  • I have added relevant documentation. (N/A)
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

Running yarn lint on main reformats 14 files under config-ui/src. The
lint script runs eslint . --fix with eslint-plugin-prettier, so the CI
job fixes the formatting in its own checkout and passes, and the drift is
never reported.

This PR commits exactly what yarn lint produces. It is a formatting-only
change (line wrapping); there is no code change.

Does this close any open issues?

No.

Screenshots

N/A

Other Information

  • yarn lint: 0 errors (the 18 existing warnings are unchanged); yarn test:
    92 tests pass.
  • Prettier 3.10.1 (build(deps): bump the js-minor-patch group in /config-ui with 4 updates #9397) formats these files the same way, so the two PRs do
    not conflict.
  • Question for the maintainers: should the config-ui workflow fail on
    unformatted code, for example by running eslint . without --fix in CI,
    or git diff --exit-code after yarn lint? I can send that as a follow-up
    if you want it.

`yarn lint` runs `eslint . --fix` with the prettier plugin, so CI fixes
formatting in its checkout but never fails on it, and 14 files drifted.
Commit the output of `yarn lint`; formatting only, no code change.
Prettier 3.10.1 (apache#9397) produces the same result.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant