Repository navigation
Conversation
Use recursive $(MAKE) for the CMake-generated build and install targets so they inherit the parent jobserver. The fixed -j8 and -j10 values bypassed the parent's limit.
Member
|
Aha. I would like to provide some context for your reference: #1002 (comment). I'm not sure whether the comment is suitable for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace the hard-coded
make -j8andmake -j10calls in the PAX build and install recipes with$(MAKE)so both recursive invocations share the parent GNU Make job limit.Type of Change
Breaking Changes
None.
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelWith a parent
make -j2:installtarget dropped from 10 to 2.Impact
PAX build and install jobs now count toward the limit set by the parent
make -jN.Checklist
Additional Context
This change applies to the GNU Make/CMake build path.