Repository navigation
Conversation
gprecoverseg reads gpArray.standbyCoordinator when the cluster has no mirrors (c867979). The test uses MagicMock(spec=GpArray), and standbyCoordinator is set in GpArray.__init__(), not on the class. So the mock has no such attribute and test_gprecoverseg_with_mirrorless failed with an AttributeError. Set standbyCoordinator to None on the mock. Backpatch-through: REL_2_STABLE Assisted-by: Claude Code
tuhaihe
marked this pull request as draft
November 20, 2026 07:01
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
gprecoverseg reads gpArray.standbyCoordinator when the cluster has no
mirrors (c867979). The test uses MagicMock(spec=GpArray), and
standbyCoordinator is set in GpArray.init(), not on the class. So
the mock has no such attribute and test_gprecoverseg_with_mirrorless
failed with an AttributeError.
Set standbyCoordinator to None on the mock.
Type of Change
Test Plan
gppylib.test.unit.test_unit_gprecoversegpasses as gpadmin in a cbdb-build-rocky9 container with mock 5.0.0 and ademo cluster, run from
gpMgmt/binwith:Checklist
Additional Context
No CI job runs this module today, which is why the failure was not seen.
I found it while adding the gpMgmt unit tests to the Behave workflow
(branch
ci-more-gpmgmt-unit-tests). After that change and this PRare merged,
gppylib.test.unit.test_unit_gprecoversegcan be added to theic-unit-gpmgmtlist.