Repository navigation
Conversation
…tering users Currently, when modifying user permissions, a SUPERUSER is downgraded to NOSUPERUSER and automatically assigned from admin_group to default_group, which is reasonable from a security perspective. However, it would be a bit superfluous for a NOSUPERUSER to be elevated to SUPERUSER and automatically assigned to admin_group. Moreover, the above reassignment actions were carried out silently without any prompts or warnings. So, make the following changs: 1. A SUPERUSER is downgraded to NOSUPERUSER, automatically assigned from admin_group to default_group, and a prompt is given. 2. NOSUPERUSER is elevated to SUPERUSER without reassigning resource group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the rule for automatically assigning resource groups after altering users
What does this PR do?
Currently, when modifying user permissions, a SUPERUSER is downgraded to NOSUPERUSER and automatically assigned from admin_group to default_group, which is reasonable from a security perspective. However, it would be a bit superfluous for a NOSUPERUSER to be elevated to SUPERUSER and automatically assigned to admin_group. Moreover, the above reassignment actions were carried out silently without any prompts or warnings.
So, make the following changs:
Phenomenon before modification:
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions