Repository navigation
Drop a relative include from array_userfuncs.c - #2198
Merged
Merged
Conversation
Member
Author
|
We found this issue in #1940. |
array_userfuncs.c includes ../../catalog/pg_type_d.h, a path relative to its own directory that names the header the catalog build generates into src/backend/catalog. It resolves only when the generated header sits at that spot next to the source, as in an in-tree build. The line adds nothing: the file already includes catalog/pg_type.h, which includes catalog/pg_type_d.h through the include path. Upstream's array_userfuncs.c has no such line; it came in with the parallel array_agg work. Assisted-by: Claude Code
tuhaihe
force-pushed
the
fix-array-userfuncs-include
branch
from
November 10, 2026 23:07
7cf6381 to
1cfecdd
Compare
tuhaihe
enabled auto-merge (rebase)
November 10, 2026 23:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array_userfuncs.c includes
../../catalog/pg_type_d.h, a path relative to its own directory that names the header the catalog build generates intosrc/backend/catalog. It resolves only when the generated header sits at that spot next to the source, as in an in-tree build.The line adds nothing: the file already includes
catalog/pg_type.h, which includescatalog/pg_type_d.hthrough the include path. Upstream's array_userfuncs.c has no such line; it came in with the parallel array_agg work.Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions