Skip to content

Drop a relative include from array_userfuncs.c - #2198

Merged
tuhaihe merged 1 commit into
apache:mainfrom
tuhaihe:fix-array-userfuncs-include
Nov 11, 2026
Merged

tuhaihe merged 1 commit into
apache:mainfrom
tuhaihe:fix-array-userfuncs-include

Conversation

@tuhaihe

@tuhaihe tuhaihe commented Oct 27, 2026

Copy link
Copy Markdown
Member

array_userfuncs.c includes ../../catalog/pg_type_d.h, a path relative to its own directory that names the header the catalog build generates into src/backend/catalog. It resolves only when the generated header sits at that spot next to the source, as in an in-tree build.

The line adds nothing: the file already includes catalog/pg_type.h, which includes catalog/pg_type_d.h through the include path. Upstream's array_userfuncs.c has no such line; it came in with the parallel array_agg work.

Assisted-by: Claude Code

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@tuhaihe tuhaihe added this to the 3.0 milestone Oct 27, 2026
@tuhaihe

tuhaihe commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

We found this issue in #1940.

@tuhaihe tuhaihe modified the milestones: 3.0, 3.x Meson Oct 27, 2026

@leborchuk leborchuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alena0704 Alena0704 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

array_userfuncs.c includes ../../catalog/pg_type_d.h, a path relative
to its own directory that names the header the catalog build generates
into src/backend/catalog. It resolves only when the generated header
sits at that spot next to the source, as in an in-tree build.

The line adds nothing: the file already includes catalog/pg_type.h,
which includes catalog/pg_type_d.h through the include path. Upstream's
array_userfuncs.c has no such line; it came in with the parallel
array_agg work.

Assisted-by: Claude Code
@tuhaihe
tuhaihe force-pushed the fix-array-userfuncs-include branch from 7cf6381 to 1cfecdd Compare November 10, 2026 23:07
@tuhaihe
tuhaihe enabled auto-merge (rebase) November 10, 2026 23:08
@tuhaihe
tuhaihe merged commit baf3bb0 into apache:main Nov 11, 2026
206 of 207 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants