Skip to content

Fix redeclared $macro in gen_node_support.pl - #2190

Merged
tuhaihe merged 1 commit into
apache:mainfrom
tuhaihe:fix-node-support-macro-redeclare
Nov 15, 2026
Merged

tuhaihe merged 1 commit into
apache:mainfrom
tuhaihe:fix-node-support-macro-redeclare

Conversation

@tuhaihe

@tuhaihe tuhaihe commented Oct 26, 2026

Copy link
Copy Markdown
Member

The read-fast block of gen_node_support.pl declared "my $macro" a second time in the same scope as the read block just above it, computing the same value, so every build that generates node support prints

  "my" variable $macro masks earlier declaration in same scope at
  gen_node_support.pl line 1035.

Reuse the variable from the read block instead. The generated files are unchanged.

Assisted-by: Claude Code

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@tuhaihe tuhaihe mentioned this pull request Oct 26, 2026
1 of 13 tasks
@tuhaihe tuhaihe added this to the 3.0 milestone Oct 26, 2026

@leborchuk leborchuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no need to declare it twice

@tuhaihe tuhaihe modified the milestones: 3.0, 3.x Meson Oct 27, 2026
@tuhaihe
tuhaihe enabled auto-merge (rebase) November 15, 2026 11:58
The read-fast block of gen_node_support.pl declared "my $macro" a second
time in the same scope as the read block just above it, computing the
same value, so every build that generates node support prints

  "my" variable $macro masks earlier declaration in same scope at
  gen_node_support.pl line 1035.

Reuse the variable from the read block instead. The generated files are
unchanged.

Assisted-by: Claude Code
@tuhaihe
tuhaihe force-pushed the fix-node-support-macro-redeclare branch from d23179d to 7916d65 Compare November 15, 2026 11:58
@tuhaihe
tuhaihe merged commit 6ac0b8b into apache:main Nov 15, 2026
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants