You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug] gp_distribution_policy reports randomly distributed and replicated tables as misplaced #2343
gp_table_distribution_check() from gpcontrib/gp_distribution_policy returns false for most
segments of a randomly distributed table and of a replicated table, although the data is placed
correctly. For a hash-distributed table it returns true on every segment, as expected.
gp_distribution_policy_table_check() hashes the distribution key columns of each row and compares
the target segment with the current segment. It does not look at the policy type. A randomly
distributed or replicated table has no distribution key columns (policy->nattrs = 0), so every row
hashes to the same target segment, and the function reports every other segment that holds rows as
wrong. In the run below that target is segment 0.
What you think should happen instead
For a randomly distributed table, any placement is valid, so the function should return true. For
a replicated table, every segment holds a full copy, so it should return true, or check that the
copies are complete. Alternatively, the function should reject tables that are not hash-distributed
with a clear error.
How to reproduce
CREATE EXTENSION gp_distribution_policy;
CREATETABLEdhash (a int) DISTRIBUTED BY (a); INSERT INTO dhash SELECT generate_series(1, 100);
CREATETABLEdrand (a int) DISTRIBUTED RANDOMLY; INSERT INTO drand SELECT generate_series(1, 100);
CREATETABLEdrep (a int) DISTRIBUTED REPLICATED; INSERT INTO drep SELECT generate_series(1, 100);
SELECT'hash'AS t, *FROM gp_table_distribution_check('dhash')
UNION ALLSELECT'random', *FROM gp_table_distribution_check('drand')
UNION ALLSELECT'replicated', *FROM gp_table_distribution_check('drep')
ORDER BY1, 2;
Output on a 3-segment demo cluster (identical on both branches):
t | gp_segment_id | is_distribution_correct
------------+---------------+-------------------------
hash | 0 | t
hash | 1 | t
hash | 2 | t
random | 0 | t
random | 1 | f
random | 2 | f
replicated | 0 | t
replicated | 1 | f
replicated | 2 | f
Operating System
Rocky Linux 9.7 (apache/incubator-cloudberry:cbdb-build-rocky9-latest), built with devops/build/automation/cloudberry/scripts.
Anything else
gp_distribution_policy_table_check(regclass) is declared IMMUTABLE in gp_distribution_policy--1.0.sql (provolatile = 'i'), although it reads table data. It should be VOLATILE, which is also what the comment in the C file says. We did not observe a wrong result
caused by this.
Activity