Repository navigation
Conversation
A concurrent TRUNCATE can replace table storage after the backup snapshot but before table locks are acquired. Backup and restore can then report success while restoring an empty table. On Cloudberry, validate storage and table identity after locking, including descendant partitions. Add --snapshot-attempts (default 3) to retry with a fresh shared snapshot, rebuild filters, and discard heap file hashes. Fail the backup when the limit is reached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gpbackuptakes its snapshot before acquiring table locks. ConcurrentTRUNCATEcan replace storage while it waits, so backup and restore report success but restore an empty table, hiding data loss.Reproduction
{1,2,3}on Cloudberry.TRUNCATEand insert{4,5,6}without committing.gpbackup, wait untilpg_locksshows the backup waiting forAccessShareLockon this table, then commit the writer.0, but the restored table is empty.Fix
--snapshot-attempts(default3) to retry with a fresh shared snapshot and fail the backup when attempts are exhausted.