Repository navigation
Let SortAndBatchElements batches reach max_batch_weight - #40462
Merged
shunping merged 1 commit intoOct 8, 2026
Merged
Conversation
A batch was cut when adding the next element would make it equal to max_batch_weight, so it never reached the limit. Use > like BatchElements. fixes apache#40461
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40462 +/- ##
=============================================
+ Coverage 59.04% 79.56% +20.51%
=============================================
Files 2797 487 -2310
Lines 280750 82225 -198525
Branches 12488 0 -12488
=============================================
- Hits 165764 65420 -100344
+ Misses 108540 16805 -91735
+ Partials 6446 0 -6446
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Assigning reviewers: R: @shunping for label python. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
shunping
approved these changes
Oct 8, 2026
shunping
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SortAndBatchElementscut a batch when adding the next element would make it weigh exactlymax_batch_weight, so batches never reached the limit. Four size-5 elements withmax_batch_weight=10came out as four batches of one instead of two batches of two.Both DoFns now use
>for the weight check, same asBatchElements. Added a test for each DoFn that fails on master;util_test.pypasses.fixes #40461
Written with help from Claude.
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.