Repository navigation
Fix uncaught permission exception in VertexAIFeatureStoreEnrichmentHandler - #40443
Closed
vishalmore90 wants to merge 4 commits into
Closed
vishalmore90 wants to merge 4 commits into
vishalmore90 wants to merge 4 commits into
Conversation
Contributor
|
Assigning reviewers: R: @shunping for label python. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
vishalmore90
force-pushed
the
fix-issue-40442
branch
from
October 7, 2026 06:36
aeabe41 to
a1aabeb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40443 +/- ##
============================================
+ Coverage 56.14% 56.20% +0.06%
Complexity 2288 2288
============================================
Files 1121 1123 +2
Lines 177151 178189 +1038
Branches 1488 1488
============================================
+ Hits 99466 100157 +691
- Misses 75161 75508 +347
Partials 2524 2524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #40442
Context
VertexAIFeatureStoreEnrichmentHandleris designed to log a warning and proceed if the user lacks sufficient admin permissions to verify the feature store's existence during initialization. However, theget_feature_online_storeRPC call—which actually performs the permission check—was placed in theelseblock of thetry...except Exceptionstructure. This causedPermissionDeniederrors to bypass the intended fallback and crash the pipeline.Changes
Moved
get_feature_online_storeand its path resolution methods out of theelseblock and into thetryblock. This correctly catches exceptions (e.g.,PermissionDenied) thrown during the RPC call and triggers the intended_LOGGER.warningfallback.Verification
try...exceptcontrol flow.py_compile.Checklist
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.