Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms by jbonofre · Pull Request #38729 · apache/beam

jbonofre · 2026-05-28T15:19:22Z

Migrate JmsIO to jakarta.jms (JMS 3.1) with ActiveMQ 6.2.5 and qpid-jms-client 2.10.0. Replaces geronimo-jms_2.0_spec with jakarta.jms-api 3.1.0 and renames all javax.jms imports to jakarta.jms in main and test sources.

JmsIO now requires Java 17. AMQP and MQTT modules are unaffected (kept on ActiveMQ 5.19.2 via a separate activemq6_* library entry).

gemini-code-assist · 2026-05-28T15:19:37Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the JmsIO module by migrating from the legacy javax.jms namespace to the Jakarta Messaging API (jakarta.jms). This change involves updating core dependencies to versions that support the Jakarta EE standard, ensuring compatibility with modern messaging infrastructure.

Highlights

Dependency Upgrades: Updated ActiveMQ to 6.2.5 and qpid-jms-client to 2.10.0 to support modern JMS standards.
Jakarta EE Migration: Replaced the legacy geronimo-jms_2.0_spec with jakarta.jms-api 3.1.0 and migrated all javax.jms imports to jakarta.jms across the JmsIO module.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request migrates the JMS IO module from the legacy javax.jms namespace to the modern jakarta.jms namespace, upgrading ActiveMQ to 6.2.5, Qpid JMS Client to 2.10.0, and adopting jakarta.jms-api:3.1.0. The review feedback identifies critical Java compatibility issues with these upgrades: ActiveMQ 6.x requires Java 17, while Qpid JMS Client 2.x and Jakarta JMS API 3.1.0 require Java 11, which would break Apache Beam's Java 8 and Java 11 compatibility. The reviewer suggests downgrading the Jakarta JMS API to 3.0.0 to maintain Java 8 support and requests verification on how compatibility will be maintained for the other dependencies.

github-actions · 2026-05-28T18:05:12Z

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions · 2026-06-22T23:03:43Z

Assigning reviewers:

R: @ahmedabu98 for label java.
R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

damccorm

This generally seems fine, but trying to understand the goals. What benefits do we get from the upgrade? It does come at a Java version cost, so want to make sure we're making the right tradeoff.

cc/ @Abacn

damccorm · 2026-06-30T14:27:03Z

+// map. Because the global resolution strategy forces every mapped version,
+// that 6.2.5 would otherwise be forced onto this Java 11 module via the shared
+// org.apache.activemq coordinates. MQTT IO only needs ActiveMQ as an embedded
+// test broker, so pin it back to the Java 11-compatible 5.x line.


I see a couple of mentions of making this compatible with Java 11, but then we're forcing Java 17 - do we actually need to force Java 17 or can we just require Java 11?

ActiveMQ is a test dependency for AmqpIO, MqttIO, JmsIO. Instead of modifying build.gradle in the former ones, can we just pin to ActiveMQ 6 in JmsIO? This should give a smaller diff and safer as it doesn't do a global upgrade.

PS: I'm thinking about we should move our Infra to Java17 (probably Java21, to reduce the frequency of this kind of upgrade) while keep Java11 compatibility via cross-compilation. We already use Java21 to publish Javadoc

jbonofre · 2026-06-30T14:32:10Z

@damccorm the goal is to support the latest JMS spec version and so latest ActiveMQ version.

damccorm · 2026-06-30T19:36:58Z

Sounds good - I'm good with the change pending the one open comment thread

Abacn · 2026-07-01T15:59:43Z

Also, JmsIO used to have some weird checkpointing behavior to accommondate Jms spec

In JMS, acknowledging one message automatically acknowledges all messages processed by that specific session up to that point

This caused data loss due to Beam process and commit messages asynchronously. We ended up creating different sessions for each checkpointing: #30054

SInce this is a Jms spec upgrade, let me check if any breaking changes could happen especially checkpointing logics

github-actions · 2026-07-09T13:24:27Z

Reminder, please take a look at this pr: @ahmedabu98 @damccorm @kennknowles

github-actions · 2026-07-23T12:43:17Z

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.
R: @damccorm for label build.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Abacn · 2026-07-23T14:03:50Z

Updates: there will be significant changes in JmsIO (support ACKNOWLEDGE_MODE and Python xlang support) in next release. Current plan is to have one (or two) stable version before we moving to Java17

kennknowles · 2026-07-23T20:27:06Z

R: @Abacn
R: @damccorm

also LGTM but leaving to you guy to confirm the comment thread is done

github-actions · 2026-07-23T20:28:25Z

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

damccorm · 2026-08-21T13:05:52Z

@Abacn @jbonofre now that we're past the release cut, what are next steps? Should we clean this PR up and move forward with it or wait longer?

jbonofre · 2026-08-21T13:07:47Z

@damccorm I will rebase. I think this PR is good to go after rebase.

derrickaw · 2026-09-24T19:58:12Z

Hi @jbonofre, will you be rebasing soon? thanks

codecov · 2026-10-07T18:46:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.75%. Comparing base (76f6e6d) to head (df1695b).
⚠️ Report is 96 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #38729      +/-   ##
============================================
+ Coverage     56.16%   58.75%   +2.58%     
- Complexity     2288    13918   +11630     
============================================
  Files          1124     2585    +1461     
  Lines        178336   271699   +93363     
  Branches       1489    11243    +9754     
============================================
+ Hits         100170   159636   +59466     
- Misses        75645   106060   +30415     
- Partials       2521     6003    +3482

Flag	Coverage Δ
java	`65.26% <ø> (-10.52%)`	⬇️
python	`79.61% <ø> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

derrickaw · 2026-10-08T00:12:55Z

R: @damccorm @Abacn

Abacn · 2026-10-08T00:25:41Z

      - name: Setup environment
        uses: ./.github/actions/setup-environment-action
        with:
+          java-version: '17'


We no longer need these lines as the CI is on Java 21 currently

updated, thanks

Abacn · 2026-10-08T00:29:02Z

        activemq_junit                              : "org.apache.activemq.tooling:activemq-junit:$activemq_version",
        activemq_kahadb_store                       : "org.apache.activemq:activemq-kahadb-store:$activemq_version",
        activemq_mqtt                               : "org.apache.activemq:activemq-mqtt:$activemq_version",
+        activemq6_amqp                              : "org.apache.activemq:activemq-amqp:$activemq6_version",


if activemq 5 and 6 have same package name, BeamModulePlugin version resolution doesn't work well as it tries to enforce a version it first see. As you may have already noticed and added force resolution in io.amqp

Consider simply bump activemq deps to v6 and pin to v5 in activemq, which has same effect

thanks, done

Bump activemq to 6.2.5 and qpid-jms-client to 2.10.0, both of which target jakarta.jms. Replace the geronimo-jms_2.0_spec dependency with jakarta.jms-api 3.1.0 and migrate all javax.jms imports and javadoc references in JmsIO main and test sources to jakarta.jms.

Abacn

Thanks!

github-actions Bot added java build io jms labels May 28, 2026

gemini-code-assist Bot reviewed May 28, 2026

View reviewed changes

Comment thread buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

Comment thread buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

Comment thread sdks/java/io/jms/build.gradle

jbonofre force-pushed the jms-activemq-6.2.5-jakarta branch 7 times, most recently from 52fe765 to dc7ebca Compare June 22, 2026 18:14

github-actions Bot added amqp mqtt labels Jun 22, 2026

jbonofre force-pushed the jms-activemq-6.2.5-jakarta branch 2 times, most recently from a1f3ae2 to a85672c Compare June 22, 2026 20:33

github-actions Bot added the Next Action: Reviewers label Jun 22, 2026

jbonofre requested review from ahmedabu98, damccorm and kennknowles June 25, 2026 05:25

damccorm reviewed Jun 30, 2026

View reviewed changes

Abacn mentioned this pull request Jul 2, 2026

Bump CI Java version to Java21 #39205

Merged

3 tasks

derrickaw mentioned this pull request Jul 8, 2026

build(deps): bump org.apache.activemq:activemq-client from 5.19.2 to 6.2.7 GoogleCloudPlatform/DataflowTemplates#4004

Closed

github-actions Bot added the slow-review label Jul 21, 2026

github-actions Bot removed the slow-review label Jul 23, 2026

Abacn mentioned this pull request Jul 23, 2026

[Feature Request]: Update JmsIO to use jakarta packages #28779

Open

1 of 16 tasks

kennknowles requested review from Abacn and damccorm and removed request for ahmedabu98 and kennknowles July 23, 2026 20:27

damccorm removed their request for review October 1, 2026 16:24

derrickaw force-pushed the jms-activemq-6.2.5-jakarta branch from a85672c to e7961f1 Compare October 7, 2026 18:02

github-actions Bot added the python label Oct 7, 2026

derrickaw mentioned this pull request Oct 7, 2026

build(deps): bump org.apache.activemq:activemq-client from 5.19.9 to 6.3.2 GoogleCloudPlatform/DataflowTemplates#4390

Open

github-actions Bot added the yaml label Oct 7, 2026

Abacn reviewed Oct 8, 2026

View reviewed changes

jbonofre and others added 5 commits October 8, 2026 17:00

more changes to update PR to accomodate other merged related PRs

74f255a

fix yaml related files

67df1a2

try to fix jms flaky tests

f0fd261

address reviewers' comments

df1695b

derrickaw force-pushed the jms-activemq-6.2.5-jakarta branch from 3792538 to df1695b Compare October 8, 2026 17:01

Abacn approved these changes Oct 8, 2026

View reviewed changes

Abacn merged commit 40852a7 into apache:master Oct 8, 2026
114 of 116 checks passed

Conversation

jbonofre commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented May 28, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

damccorm left a comment

Choose a reason for hiding this comment

Uh oh!

damccorm Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

jbonofre commented Jun 30, 2026

Uh oh!

damccorm commented Jun 30, 2026

Uh oh!

Abacn commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

Abacn commented Jul 23, 2026

Uh oh!

kennknowles commented Jul 23, 2026

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

damccorm commented Aug 21, 2026

Uh oh!

jbonofre commented Aug 21, 2026

Uh oh!

derrickaw commented Sep 24, 2026

Uh oh!

codecov Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

derrickaw commented Oct 8, 2026

Uh oh!

Abacn Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

derrickaw Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

derrickaw Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

jbonofre commented May 28, 2026 •

edited

Loading

Abacn commented Jul 1, 2026 •

edited

Loading

codecov Bot commented Oct 7, 2026 •

edited

Loading