Skip to content

ARROW-9913: [C++] Make outputs of Decimal128::FromString independent of the presence of one another. - #8109

Closed
MingyuZhong wants to merge 1 commit into
apache:masterfrom
MingyuZhong:bn4
Closed

MingyuZhong wants to merge 1 commit into
apache:masterfrom
MingyuZhong:bn4

Conversation

@MingyuZhong

Copy link
Copy Markdown
Contributor

No description provided.

std::numeric_limits<uint64_t>::max(),
};
static constexpr int32_t kScales[] = {-10, -1, 0, 1, 10};
static constexpr int32_t kScales[] = {0, 1, 10};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to add another test how this code behaves when scale is negative or is that already tested elsewhere?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions

github-actions Bot commented Sep 3, 2020

Copy link
Copy Markdown

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this looks like a nice API fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants