Skip to content

GH-40825: [Java] Adding Spotless to Flight module - #42063

Merged
lidavidm merged 1 commit into
apache:mainfrom
vibhatha:feat-spotless-flight
Jun 11, 2024
Merged

lidavidm merged 1 commit into
apache:mainfrom
vibhatha:feat-spotless-flight

Conversation

@vibhatha

@vibhatha vibhatha commented Jun 10, 2024 •

Copy link
Copy Markdown
Contributor

Rationale for this change

Adding code style and formatting options for Flight module.

  • flight-core
  • flight-integration-tests
  • flight-sql
  • flight-sql-jdbc-core
  • flight-sql-jdbc-driver

What changes are included in this PR?

Code formatting spotless plugin has been added.

Some explicit involvement required for the following

[WARN] /home/vibhatha/github/fork/arrow/java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightProducer.java:94:3: Missing a Javadoc comment. [MissingJavadocMethod]
Audit done.
[WARNING] src/main/java/org/apache/arrow/flight/FlightProducer.java:[94,3] (javadoc) MissingJavadocMethod: Missing a Javadoc comment.
[WARN] /home/vibhatha/github/fork/arrow/java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/AvaticaParameterBinder.java:58:3: Missing a Javadoc comment. [MissingJavadocMethod]
Audit done.
[WARNING] src/main/java/org/apache/arrow/driver/jdbc/utils/AvaticaParameterBinder.java:[58,3] (javadoc) MissingJavadocMethod: Missing a Javadoc comment.
AvaticaParameterBinder constructor java docs manually added

These docs have been explicitly added.

Are these changes tested?

Yes, but doesn't involve test cases, the plugin itself corrects.

@vibhatha

Copy link
Copy Markdown
Contributor Author

@lidavidm this diff is too large, should we go for per sub-module?

@vibhatha
vibhatha marked this pull request as ready for review June 10, 2024 15:04
@vibhatha
vibhatha requested a review from lidavidm as a code owner June 10, 2024 15:04
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit ea82f3e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
### Rationale for this change

Adding code style and formatting options for Flight module. 

- [X] flight-core
- [X] flight-integration-tests
- [X] flight-sql
- [X] flight-sql-jdbc-core
- [X] flight-sql-jdbc-driver

### What changes are included in this PR?

Code formatting spotless plugin has been added. 

Some explicit involvement required for the following

```
[WARN] /home/vibhatha/github/fork/arrow/java/flight/flight-core/src/main/java/org/apache/arrow/flight/FlightProducer.java:94:3: Missing a Javadoc comment. [MissingJavadocMethod]
Audit done.
[WARNING] src/main/java/org/apache/arrow/flight/FlightProducer.java:[94,3] (javadoc) MissingJavadocMethod: Missing a Javadoc comment.
```

```
[WARN] /home/vibhatha/github/fork/arrow/java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/AvaticaParameterBinder.java:58:3: Missing a Javadoc comment. [MissingJavadocMethod]
Audit done.
[WARNING] src/main/java/org/apache/arrow/driver/jdbc/utils/AvaticaParameterBinder.java:[58,3] (javadoc) MissingJavadocMethod: Missing a Javadoc comment.
AvaticaParameterBinder constructor java docs manually added
```

These docs have been explicitly added. 

### Are these changes tested?

Yes, but doesn't involve test cases, the plugin itself corrects. 

* GitHub Issue: apache#40825

Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants