Repository navigation
Conversation
pitrou
marked this pull request as draft
July 28, 2021 15:58
Member
Author
|
@emkornfield @cyb70289 Do you want to take a look at this? |
cyb70289
reviewed
Jul 29, 2021
pitrou
force-pushed
the
ARROW-9948-decimal-from-string
branch
from
July 29, 2021 16:36
258e9c1 to
8704910
Compare
pitrou
commented
Jul 29, 2021
Member
Author
There was a problem hiding this comment.
@bkietz What do you think about this constructor scheme? Is it ok, or is there a better option?
Member
There was a problem hiding this comment.
I'd say it's not idiomatic arrow; I'd expect something like:
Suggested change
| : BasicDecimal128(BitUtil::LittleEndianArray::ToNative(array)) {} | |
| static BasicDecimal128 FromLittleEndianArray(const std::array<uint64_t, 2>& array) noexcept { | |
| return {BitUtil::LittleEndianArray::ToNative(array)}; | |
| } |
... but then we'll have to repeat the declaration for non Basic decimal types.
Member
Author
There was a problem hiding this comment.
Well, yes, having to repeat the declaration is the problem here.
pitrou
force-pushed
the
ARROW-9948-decimal-from-string
branch
2 times, most recently
from
July 29, 2021 16:43
830b0f1 to
1475fda
Compare
pitrou
commented
Jul 29, 2021
* The wrong scale could be inferred if the input both had fractional digits and an exponent * An out-of-bounds access could be provoked when correcting an excessive negative scale (for example "1e39")
pitrou
force-pushed
the
ARROW-9948-decimal-from-string
branch
from
August 2, 2021 10:04
1475fda to
5d694f1
Compare
pitrou
marked this pull request as ready for review
August 2, 2021 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.